Allow LCD text to batch across colorchanges. This will always use

Allow LCD text to batch across colorchanges.  This will always use
color vertices, even when we can't batch across color changes

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d9d30f7b577711a200395f7b62acc0d82a19f9c3

[joshualitt, 2015-12-08 16:11:56]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, jvanverth@google.com

[joshualitt, 2015-12-08 16:11:57]

ptal

[bsalomon, 2015-12-08 16:27:14]

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:1076: bool useColorVerts = true;
?

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrBitma...
File src/gpu/effects/GrBitmapTextGeoProc.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrBitma...
src/gpu/effects/GrBitmapTextGeoProc.cpp:147: // TODO we could think about
removing this attribute if color is ignored, but unfortunately
Are we really every going to do this? Seems like we're going the other way.
Color ignored seems like a case we wouldn't optimize for.

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrDista...
File src/gpu/effects/GrDistanceFieldGeoProc.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrDista...
src/gpu/effects/GrDistanceFieldGeoProc.cpp:419: if (dfpgp.color() != fColor &&
!dfpgp.hasVertexColor()) {
Do we still need uniform color for df at all?

[jvanverth1, 2015-12-08 16:35:52]

It looks like this also batches distance field text across colors as well. Or am
I misreading it?

[joshualitt, 2015-12-08 17:04:37]

feedback inc

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.cpp:1076: bool useColorVerts = true;
On 2015/12/08 16:27:13, bsalomon wrote:
> ?

Acknowledged.

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrBitma...
File src/gpu/effects/GrBitmapTextGeoProc.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrBitma...
src/gpu/effects/GrBitmapTextGeoProc.cpp:147: // TODO we could think about
removing this attribute if color is ignored, but unfortunately
On 2015/12/08 16:27:13, bsalomon wrote:
> Are we really every going to do this? Seems like we're going the other way.
> Color ignored seems like a case we wouldn't optimize for.

Given infinite time and infinite resources...okay I remove the todo

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrDista...
File src/gpu/effects/GrDistanceFieldGeoProc.cpp (right):

https://codereview.chromium.org/1502253003/diff/40001/src/gpu/effects/GrDista...
src/gpu/effects/GrDistanceFieldGeoProc.cpp:419: if (dfpgp.color() != fColor &&
!dfpgp.hasVertexColor()) {
On 2015/12/08 16:27:13, bsalomon wrote:
> Do we still need uniform color for df at all?

I will do this in a follow on

[bsalomon, 2015-12-08 17:07:50]

lgtm

[joshualitt, 2015-12-08 17:10:34]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-12-08 17:10:37]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-12-08 18:15:43]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-08 18:15:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502253003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502253003/60001

[commit-bot: I haz the power, 2015-12-08 18:47:58]

Description was changed from

==========
Allow LCD text to batch across colorchanges.  This will always use
color vertices, even when we can't batch across color changes

BUG=skia:
==========

to

==========
Allow LCD text to batch across colorchanges.  This will always use
color vertices, even when we can't batch across color changes

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/d9d30f7b577711a200395f7b62acc0d82a19f9c3
==========

[commit-bot: I haz the power, 2015-12-08 18:47:58]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d9d30f7b577711a200395f7b62acc0d82a19f9c3

[joshualitt, 2015-12-09 15:26:55]

Description was changed from

==========
Allow LCD text to batch across colorchanges.  This will always use
color vertices, even when we can't batch across color changes

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/d9d30f7b577711a200395f7b62acc0d82a19f9c3
==========

to

==========
Allow LCD text to batch across colorchanges.  This will always use
color vertices, even when we can't batch across color changes

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/d9d30f7b577711a200395f7b62acc0d82a19f9c3
==========

[joshualitt, 2015-12-09 15:27:45]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1514563002/ by joshualitt@google.com.

The reason for reverting is: Seems to break textblobrandomfont on some
platforms.