Strong-mode error code validation "enum" (#25117).

Strong-mode error code validation "enum" (#25117).

Adds an enum of valid strong-mode error code names a la `ErrorCode.values`.

This gets used in error code validation when processing `.analysis_options`.

See: https://github.com/dart-lang/sdk/issues/25117

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/109ccdaf970a8a1e261b4f6bbcb12cfa7cc8fc4c

[pquitslund, 2015-12-05 00:31:04]

pquitslund@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[Jennifer Messerly, 2015-12-05 00:59:27]

lgtm

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:131: StaticInfo.names.any((String code)
=> code == name);
StaticInfo.names.contains?

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (right):

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:491: static const List<String> names
= const [
consider: lazy initialized Set for faster lookup?

[pquitslund, 2015-12-06 17:07:18]

Cheers John!

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:131: StaticInfo.names.any((String code)
=> code == name);
On 2015/12/05 00:59:27, John Messerly wrote:
> StaticInfo.names.contains?

Ha!  Good catch.  Done.

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (right):

https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:491: static const List<String> names
= const [
On 2015/12/05 00:59:27, John Messerly wrote:
> consider: lazy initialized Set for faster lookup?

I talked myself out of this with the ErrorCodes enum for some reason but I think
you're right.  I'll consolidate these codes and those into one HashSet in a
follow-up.

Thanks!

[pquitslund, 2015-12-06 17:10:15]

Description was changed from

==========
Strong-mode error code validation "enum" (#25117).

Adds an enum of valid strong-mode error code names a la `ErrorCode.values`.

This gets used in error code validation when processing `.analysis_options`.

See: https://github.com/dart-lang/sdk/issues/25117

BUG=
==========

to

==========
Strong-mode error code validation "enum" (#25117).

Adds an enum of valid strong-mode error code names a la `ErrorCode.values`.

This gets used in error code validation when processing `.analysis_options`.

See: https://github.com/dart-lang/sdk/issues/25117

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/109ccdaf970a8a1e261b4f6bbcb12cfa7cc8fc4c
==========

[pquitslund, 2015-12-06 17:10:17]

Committed patchset #2 (id:20001) manually as
109ccdaf970a8a1e261b4f6bbcb12cfa7cc8fc4c (presubmit successful).

[pquitslund, 2015-12-06 17:25:36]

>
https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
> File pkg/analyzer/lib/src/task/strong/info.dart (right):
> 
>
https://codereview.chromium.org/1501633003/diff/1/pkg/analyzer/lib/src/task/s...
> pkg/analyzer/lib/src/task/strong/info.dart:491: static const List<String>
names
> = const [
> consider: lazy initialized Set for faster lookup?

Ask and ye shall receive...

https://codereview.chromium.org/1505623002/

:)