Issue 1505623002: ErrorCode hashing for faster lookup in validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1505623002: ErrorCode hashing for faster lookup in validation. (Closed)

Created:
5 years ago by pquitslund

Modified:
5 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

ErrorCode hashing for faster lookup in validation. * Stores error codes in a laziliy initialized `HashSet` for speedy lookup. (Follow-up to John's comment here: https://codereview.chromium.org/1501633003/) BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/032c829246c071a96f218bbc02b17f4db5729a27

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/task/options.dart	View		3 chunks	+17 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

5 years ago (2015-12-07 19:30:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
032c829246c071a96f218bbc02b17f4db5729a27 (presubmit successful).