Strong-mode error code validation "enum" (#25117).

pkg/analyzer/lib/src/task/strong/info.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Defines static information collected by the type checker and used later by
 /// emitters to generate code.
 // TODO(jmesserly): this was ported from package:dev_compiler, and needs to be
 // refactored to fit into analyzer.
 library analyzer.src.task.strong.info;
 
@@ skipping 467 matching lines @@
   String get message;
 
   toErrorCode() => new CompileTimeErrorCode(name, message);
 }
 
 // TODO(jmesserly): this could use some refactoring. These are essentially
 // like ErrorCodes in analyzer, but we're including some details in our message.
 // Analyzer instead has template strings, and replaces '{0}' with the first
 // argument.
 abstract class StaticInfo {
+  /// Strong-mode error code names.
+  ///
+  /// Used for error code configuration validation in `.analysis_options`.
+  static const List<String> names = const [

[Jennifer Messerly, 2015/12/05 00:59:27]

consider: lazy initialized Set for faster lookup?

[pquitslund, 2015/12/06 17:07:18]

I talked myself out of this with the ErrorCodes enum for some reason but I think
you're right.  I'll consolidate these codes and those into one HashSet in a
follow-up.

Thanks!

+    //
+    // Manually populated.
+    //
+    'STRONG_MODE_ASSIGNMENT_CAST',
+    'STRONG_MODE_DOWN_CAST_COMPOSITE',
+    'STRONG_MODE_DOWN_CAST_IMPLICIT',
+    'STRONG_MODE_DYNAMIC_CAST',
+    'STRONG_MODE_DYNAMIC_INVOKE',
+    'STRONG_MODE_INFERRED_TYPE',
+    'STRONG_MODE_INFERRED_TYPE_ALLOCATION',
+    'STRONG_MODE_INFERRED_TYPE_CLOSURE',
+    'STRONG_MODE_INFERRED_TYPE_LITERAL',
+    'STRONG_MODE_INVALID_FIELD_OVERRIDE',
+    'STRONG_MODE_INVALID_METHOD_OVERRIDE',
+    'STRONG_MODE_INVALID_PARAMETER_DECLARATION',
+    'STRONG_MODE_INVALID_SUPER_INVOCATION',
+    'STRONG_MODE_INVALID_VARIABLE_DECLARATION',
+    'STRONG_MODE_NON_GROUND_TYPE_CHECK_INFO',
+    'STRONG_MODE_STATIC_TYPE_ERROR',
+    'STRONG_MODE_UNINFERRED_CLOSURE',
+  ];
+
   List<Object> get arguments => [node];
 
   String get name;
 
   /// AST Node this info is attached to.
   AstNode get node;
 
   AnalysisError toAnalysisError() {
     int begin = node is AnnotatedNode
         ? (node as AnnotatedNode).firstTokenAfterCommentAndMetadata.offset
@@ skipping 39 matching lines @@
 // TODO(vsm,leafp): Remove this.
 class UninferredClosure extends DownCast {
   UninferredClosure(TypeRules rules, FunctionExpression expression, Cast cast)
       : super._internal(rules, expression, cast);
 
   @override
   String get name => 'STRONG_MODE_UNINFERRED_CLOSURE';
 
   toErrorCode() => new StaticTypeWarningCode(name, message);
 }