Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1501463003: [Blimp Net] Client sends START_CONNECTION message (Closed)

Created:
5 years ago by haibinlu
Modified:
4 years, 7 months ago
Reviewers:
Wez
CC:
cbentzel+watch_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a protocol version file and sends START_CONNECTION message in client connection manager before handing it over to browser connection handler. TODO: Gathers client token BUG= Committed: https://crrev.com/904e7a6af0105beb2c65c5a5744b746edf15da2a Cr-Commit-Position: refs/heads/master@{#364172}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sends START_CONNECTION message in client connection manager #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : Addresses wez's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M blimp/common/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A blimp/common/protocol_version.h View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M blimp/net/client_connection_manager.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M blimp/net/client_connection_manager.cc View 1 2 3 3 chunks +16 lines, -1 line 0 comments Download
M blimp/net/client_connection_manager_unittest.cc View 1 2 3 5 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
haibinlu
will finish the unit test.
5 years ago (2015-12-03 22:59:37 UTC) #2
Wez
https://codereview.chromium.org/1501463003/diff/1/blimp/net/client_auth_handler.h File blimp/net/client_auth_handler.h (right): https://codereview.chromium.org/1501463003/diff/1/blimp/net/client_auth_handler.h#newcode23 blimp/net/client_auth_handler.h:23: class BLIMP_NET_EXPORT ClientAuthHandler : public ConnectionHandler { See comments ...
5 years ago (2015-12-04 01:40:28 UTC) #3
haibinlu
On 2015/12/04 01:40:28, Wez wrote: > https://codereview.chromium.org/1501463003/diff/1/blimp/net/client_auth_handler.h > File blimp/net/client_auth_handler.h (right): > > https://codereview.chromium.org/1501463003/diff/1/blimp/net/client_auth_handler.h#newcode23 > ...
5 years ago (2015-12-04 02:53:31 UTC) #4
haibinlu
PTAL
5 years ago (2015-12-09 01:45:49 UTC) #7
Wez
Do we need to update ClientConnectionManager tests to verify that it sends a StartConnection message? ...
5 years ago (2015-12-09 02:30:03 UTC) #8
Wez
lgtm
5 years ago (2015-12-09 02:30:13 UTC) #9
haibinlu
On 2015/12/09 02:30:03, Wez wrote: > Do we need to update ClientConnectionManager tests to verify ...
5 years ago (2015-12-09 19:40:22 UTC) #10
haibinlu
https://codereview.chromium.org/1501463003/diff/40001/blimp/common/protocol_version.cc File blimp/common/protocol_version.cc (right): https://codereview.chromium.org/1501463003/diff/40001/blimp/common/protocol_version.cc#newcode9 blimp/common/protocol_version.cc:9: const int kProtocolVersion = 0; On 2015/12/09 02:30:03, Wez ...
5 years ago (2015-12-09 19:40:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501463003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501463003/60001
5 years ago (2015-12-09 19:43:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/153416)
5 years ago (2015-12-09 21:01:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501463003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501463003/60001
5 years ago (2015-12-09 21:07:54 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-09 22:14:10 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-09 22:15:49 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/904e7a6af0105beb2c65c5a5744b746edf15da2a
Cr-Commit-Position: refs/heads/master@{#364172}

Powered by Google App Engine
This is Rietveld 408576698