blimp/common/protocol_version.cc - Issue 1501463003: [Blimp Net] Client sends START_CONNECTION message

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/protocol_version.cc

Issue 1501463003: [Blimp Net] Client sends START_CONNECTION message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "blimp/net/common.h"	5 #include "blimp/common/protocol_version.h"

6	6

7 namespace blimp {	7 namespace blimp {

8	8

9 const size_t kMaxPacketPayloadSizeBytes = 1 << 16; // 64KB	9 const int kProtocolVersion = 0;
	Wez 2015/12/09 02:30:03 Do we need a cc file for this, or could we remove Do we need a cc file for this, or could we remove the extern in the header and provide the value directly? I'm not sure what the guidelines are for PoD consts in headers... haibinlu 2015/12/09 19:40:34 removed cc file. Show quoted text On 2015/12/09 02:30:03, Wez wrote: > Do we need a cc file for this, or could we remove the extern in the header and > provide the value directly? I'm not sure what the guidelines are for PoD consts > in headers... removed cc file.
10 const size_t kPacketHeaderSizeBytes = 4;

11	10

12 } // namespace blimp	11 } // namespace blimp

OLD	NEW