[Blimp Net] Client sends START_CONNECTION message

blimp/net/client_auth_handler.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_NET_CLIENT_AUTH_HANDLER_H_
+#define BLIMP_NET_CLIENT_AUTH_HANDLER_H_
+
+#include <vector>
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/timer/timer.h"
+#include "blimp/net/blimp_net_export.h"
+#include "blimp/net/connection_handler.h"
+
+namespace blimp {
+
+class BlimpConnection;
+class BlimpMessage;
+
+// Sends authenticate message to the engine and hand connections over to
+// |connection_handler| right away.
+class BLIMP_NET_EXPORT ClientAuthHandler : public ConnectionHandler {

[Wez, 2015/12/04 01:40:28]

See comments re EngineAuthHandler naming.

Based on the description, do we actually need this class? All it does it write a
message to the connection, then hand-off to the main handler, so could we
instead wrap that in a SendAuthenticationMessage() function in the client
connection manager..?

The need to include checkpointing data means that we really want this message to
be sent by the client session object, as soon as the underlying channel is
ready, I think - either that or split StartConnection into separate
authentication and checkpoint messages that we happen to send consecutively -
WDYT?

+ public:
+  // Caller is responsible for ensuring that |connection_handler| outlives
+  // |this|.
+  explicit ClientAuthHandler(ConnectionHandler* connection_handler);
+
+  ~ClientAuthHandler() override;
+
+  // ConnectionHandler implementation.
+  void HandleConnection(scoped_ptr<BlimpConnection> connection) override;
+
+ private:
+  // Gathers client token and checkpoints and creates a blimp message to
+  // send to the engine.
+  scoped_ptr<BlimpMessage> CreateAuthMessage();
+
+  ConnectionHandler* connection_handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClientAuthHandler);
+};
+
+}  // namespace blimp
+
+#endif  // BLIMP_NET_CLIENT_AUTH_HANDLER_H_