Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1500663003: Removing references to webrtc::PortAllocatorFactoryInterface. (Closed)

Created:
5 years ago by Taylor_Brandstetter
Modified:
5 years ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing references to webrtc::PortAllocatorFactoryInterface. Now using a new CreatePeerConnection method that takes a PortAllocator as input. This removes the need for some boilerplate code and code duplication between webrtc and chromium. It also fixes an issue with TURN candidate priorities. BUG=webrtc:5209 Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d Cr-Commit-Position: refs/heads/master@{#364544}

Patch Set 1 #

Patch Set 2 : Fixing merge conflict, and removing some dead code. #

Total comments: 2

Patch Set 3 : Re-adding PortAllocatorFactoryInterface, for use with WebrtcTransport. #

Total comments: 5

Patch Set 4 : Renaming PortAllocatorFactoryInterface, and putting in correct namespace. #

Patch Set 5 : Using scoped_ptr instead of scoped_refptr for PortAllocatorFactory. #

Patch Set 6 : Fixing patch conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -272 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 3 4 5 2 chunks +22 lines, -87 lines 0 comments Download
M content/renderer/p2p/filtering_network_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 3 chunks +0 lines, -47 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 3 chunks +4 lines, -71 lines 0 comments Download
M remoting/host/cast_extension_session.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/cast_extension_session.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 chunk +1 line, -4 lines 0 comments Download
D remoting/protocol/chromium_port_allocator_factory.h View 1 2 3 4 2 chunks +6 lines, -8 lines 0 comments Download
D remoting/protocol/chromium_port_allocator_factory.cc View 1 2 3 4 1 chunk +4 lines, -20 lines 0 comments Download
A remoting/protocol/port_allocator_factory.h View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_transport.h View 1 2 3 4 5 5 chunks +6 lines, -8 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 1 2 3 4 5 3 chunks +11 lines, -11 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (8 generated)
Taylor_Brandstetter
PTAL. A couple things to point out: With this CL, all the code for parsing/converting ...
5 years ago (2015-12-04 03:27:51 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1500663003/diff/20001/remoting/protocol/webrtc_transport.cc File remoting/protocol/webrtc_transport.cc (left): https://codereview.chromium.org/1500663003/diff/20001/remoting/protocol/webrtc_transport.cc#oldcode111 remoting/protocol/webrtc_transport.cc:111: rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface> Pass PortAllocator instead of PortAllocatorFactory here? https://codereview.chromium.org/1500663003/diff/20001/remoting/protocol/webrtc_transport.cc File ...
5 years ago (2015-12-04 18:54:07 UTC) #4
Taylor_Brandstetter
On 2015/12/04 18:54:07, Sergey Ulanov wrote: > https://codereview.chromium.org/1500663003/diff/20001/remoting/protocol/webrtc_transport.cc > File remoting/protocol/webrtc_transport.cc (left): > > https://codereview.chromium.org/1500663003/diff/20001/remoting/protocol/webrtc_transport.cc#oldcode111 ...
5 years ago (2015-12-04 19:01:03 UTC) #5
Sergey Ulanov
On 2015/12/04 19:01:03, Taylor_Brandstetter wrote: > On 2015/12/04 18:54:07, Sergey Ulanov wrote: > > > ...
5 years ago (2015-12-04 19:13:34 UTC) #6
Taylor_Brandstetter
On 2015/12/04 19:13:34, Sergey Ulanov wrote: > On 2015/12/04 19:01:03, Taylor_Brandstetter wrote: > > On ...
5 years ago (2015-12-04 19:58:31 UTC) #7
Sergey Ulanov
On 2015/12/04 19:58:31, Taylor_Brandstetter wrote: > On 2015/12/04 19:13:34, Sergey Ulanov wrote: > > Ah, ...
5 years ago (2015-12-05 03:22:59 UTC) #8
Taylor_Brandstetter
On 2015/12/05 03:22:59, Sergey Ulanov wrote: > On 2015/12/04 19:58:31, Taylor_Brandstetter wrote: > > On ...
5 years ago (2015-12-05 04:19:45 UTC) #9
Taylor_Brandstetter
Alright; how does this look? WebrtcTransport is now basically unchanged, aside from switching from a ...
5 years ago (2015-12-07 23:38:11 UTC) #10
Sergey Ulanov
thanks for making this change. https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h File remoting/protocol/port_allocator_factory_interface.h (right): https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h#newcode13 remoting/protocol/port_allocator_factory_interface.h:13: class PortAllocatorFactoryInterface Please put ...
5 years ago (2015-12-08 16:59:44 UTC) #11
Taylor_Brandstetter
https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h File remoting/protocol/port_allocator_factory_interface.h (right): https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h#newcode13 remoting/protocol/port_allocator_factory_interface.h:13: class PortAllocatorFactoryInterface On 2015/12/08 16:59:43, Sergey Ulanov wrote: > ...
5 years ago (2015-12-08 21:02:59 UTC) #12
Sergey Ulanov
https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h File remoting/protocol/port_allocator_factory_interface.h (right): https://codereview.chromium.org/1500663003/diff/40001/remoting/protocol/port_allocator_factory_interface.h#newcode14 remoting/protocol/port_allocator_factory_interface.h:14: : public base::RefCounted<PortAllocatorFactoryInterface> { On 2015/12/08 21:02:59, Taylor_Brandstetter wrote: ...
5 years ago (2015-12-09 20:55:22 UTC) #13
Taylor_Brandstetter
Ok, I made PortAllocatorFactory non-ref-counted.
5 years ago (2015-12-10 01:05:27 UTC) #14
Sergey Ulanov
On 2015/12/10 01:05:27, Taylor_Brandstetter wrote: > Ok, I made PortAllocatorFactory non-ref-counted. LGTM, thanks
5 years ago (2015-12-10 20:22:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500663003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500663003/80001
5 years ago (2015-12-10 20:24:07 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/156325) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-10 20:30:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500663003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500663003/100001
5 years ago (2015-12-10 23:59:19 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-11 00:24:58 UTC) #24
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d Cr-Commit-Position: refs/heads/master@{#364544}
5 years ago (2015-12-11 00:26:34 UTC) #26
hans
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1514853003/ by hans@chromium.org. ...
5 years ago (2015-12-11 01:13:18 UTC) #27
Marijn Kruisselbrink
5 years ago (2015-12-11 01:15:24 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1517933002/ by mek@chromium.org.

The reason for reverting is: Seems to break build at
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698