remoting/protocol/port_allocator_factory_interface.h - Issue 1500663003: Removing references to webrtc::PortAllocatorFactoryInterface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/protocol/port_allocator_factory_interface.h

Issue 1500663003: Removing references to webrtc::PortAllocatorFactoryInterface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-adding PortAllocatorFactoryInterface, for use with WebrtcTransport. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_PROTOCOL_PORT_ALLOCATOR_FACTORY_INTERFACE_H_

	6 #define REMOTING_PROTOCOL_PORT_ALLOCATOR_FACTORY_INTERFACE_H_

	7

	8 #include "base/memory/ref_counted.h"

	9 #include "third_party/webrtc/p2p/base/portallocator.h"

	10

	11 // Factory class used for creating cricket::PortAllocator that is used

	12 // for ICE negotiation.

	13 class PortAllocatorFactoryInterface
	Sergey Ulanov 2015/12/08 16:59:43 Please put this in remoting::protocol namespace. A Please put this in remoting::protocol namespace. Also call it PortAllocatorFactory without Interface suffix. Taylor_Brandstetter 2015/12/08 21:02:59 Done. Show quoted text On 2015/12/08 16:59:43, Sergey Ulanov wrote: > Please put this in remoting::protocol namespace. Also call it > PortAllocatorFactory without Interface suffix. Done.
	14 : public base::RefCounted<PortAllocatorFactoryInterface> {
	Sergey Ulanov 2015/12/08 16:59:43 I don't think we need it to be ref-counted. Just p I don't think we need it to be ref-counted. Just pass ownership to WebrtcTransport using scoped_ptr<> Taylor_Brandstetter 2015/12/08 21:02:59 But won't every WebrtcTransport (as well as the We Show quoted text On 2015/12/08 16:59:43, Sergey Ulanov wrote: > I don't think we need it to be ref-counted. Just pass ownership to > WebrtcTransport using scoped_ptr<> But won't every WebrtcTransport (as well as the WebrtcTransportFactory that created it) have a reference to the same PortAllocatorFactory? I could make WebrtcTransportFactory use a scoped_ptr<>, and WebrtcTransport use a raw pointer, as long as WebrtcTransportFactory is guaranteed to outlive its created transports. But I wasn't sure if that was the case. Sergey Ulanov 2015/12/09 20:55:22 Yes, TransportFactory is required to outlive all T Show quoted text On 2015/12/08 21:02:59, Taylor_Brandstetter wrote: > On 2015/12/08 16:59:43, Sergey Ulanov wrote: > > I don't think we need it to be ref-counted. Just pass ownership to > > WebrtcTransport using scoped_ptr<> > > But won't every WebrtcTransport (as well as the WebrtcTransportFactory that > created it) have a reference to the same PortAllocatorFactory? > > I could make WebrtcTransportFactory use a scoped_ptr<>, and WebrtcTransport use > a raw pointer, as long as WebrtcTransportFactory is guaranteed to outlive its > created transports. But I wasn't sure if that was the case. Yes, TransportFactory is required to outlive all Transport instances it creates: https://code.google.com/p/chromium/codesearch#chromium/src/remoting/protocol/...
	15 public:

	16 virtual cricket::PortAllocator* CreatePortAllocator() = 0;

	17

	18 protected:

	19 PortAllocatorFactoryInterface() {}

	20 virtual ~PortAllocatorFactoryInterface() {}

	21

	22 friend class base::RefCounted<PortAllocatorFactoryInterface>;

	23 };

	24

	25 #endif // REMOTING_PROTOCOL_PORT_ALLOCATOR_FACTORY_INTERFACE_H_

OLD	NEW

« no previous file with comments | « remoting/protocol/chromium_port_allocator_factory.cc ('k') | remoting/protocol/webrtc_transport.h » ('j') | no next file with comments »