Revert of Removing references to webrtc::PortAllocatorFactoryInterface.

Revert of Removing references to webrtc::PortAllocatorFactoryInterface. (patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )

Reason for revert:
Broke the build:

../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
        port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
        ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor not viable: no known conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'webrtc::PortAllocatorFactoryInterface *' for 1st argument
  scoped_refptr(T* p) : ptr_(p) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor not viable: no known conversion from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
  scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template ignored: could not match 'scoped_refptr' against 'scoped_ptr'
  scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
  ^
../../base/memory/scoped_ptr.h:378:3: note: candidate function
  operator Testable() const {
  ^
1 error generated.

From https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/97032/

Original issue's description:
> Removing references to webrtc::PortAllocatorFactoryInterface.
>
> Now using a new CreatePeerConnection method that takes a
> PortAllocator as input. This removes the need for some
> boilerplate code and code duplication between webrtc and chromium.
> It also fixes an issue with TURN candidate priorities.
>
> BUG=webrtc:5209
>
> Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
> Cr-Commit-Position: refs/heads/master@{#364544}

TBR=sergeyu@chromium.org,deadbeef@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5209
Committed: https://crrev.com/ed698a70b951776aac2af82e3d7c73c6d201e1b8
Cr-Commit-Position: refs/heads/master@{#364556}

[hans, 2015-12-11 01:13:18]

Created Revert of Removing references to webrtc::PortAllocatorFactoryInterface.

[commit-bot: I haz the power, 2015-12-11 01:13:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514853003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514853003/1

[commit-bot: I haz the power, 2015-12-11 01:15:59]

Description was changed from

==========
Revert of Removing references to webrtc::PortAllocatorFactoryInterface.
(patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )

Reason for revert:
Broke the build:

../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion
from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
        port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
        ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'webrtc::PortAllocatorFactoryInterface *' for 1st argument
  scoped_refptr(T* p) : ptr_(p) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const
scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
  scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template
ignored: could not match 'scoped_refptr' against 'scoped_ptr'
  scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
  ^
../../base/memory/scoped_ptr.h:378:3: note: candidate function
  operator Testable() const {
  ^
1 error generated.

From
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

Original issue's description:
> Removing references to webrtc::PortAllocatorFactoryInterface.
> 
> Now using a new CreatePeerConnection method that takes a
> PortAllocator as input. This removes the need for some
> boilerplate code and code duplication between webrtc and chromium.
> It also fixes an issue with TURN candidate priorities.
> 
> BUG=webrtc:5209
> 
> Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
> Cr-Commit-Position: refs/heads/master@{#364544}

TBR=sergeyu@chromium.org,deadbeef@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5209
==========

to

==========
Revert of Removing references to webrtc::PortAllocatorFactoryInterface.
(patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )

Reason for revert:
Broke the build:

../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion
from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
        port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
        ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'webrtc::PortAllocatorFactoryInterface *' for 1st argument
  scoped_refptr(T* p) : ptr_(p) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const
scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
  scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template
ignored: could not match 'scoped_refptr' against 'scoped_ptr'
  scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
  ^
../../base/memory/scoped_ptr.h:378:3: note: candidate function
  operator Testable() const {
  ^
1 error generated.

From
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

Original issue's description:
> Removing references to webrtc::PortAllocatorFactoryInterface.
> 
> Now using a new CreatePeerConnection method that takes a
> PortAllocator as input. This removes the need for some
> boilerplate code and code duplication between webrtc and chromium.
> It also fixes an issue with TURN candidate priorities.
> 
> BUG=webrtc:5209
> 
> Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
> Cr-Commit-Position: refs/heads/master@{#364544}

TBR=sergeyu@chromium.org,deadbeef@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5209
==========

[commit-bot: I haz the power, 2015-12-11 01:16:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-11 01:17:11]

Description was changed from

==========
Revert of Removing references to webrtc::PortAllocatorFactoryInterface.
(patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )

Reason for revert:
Broke the build:

../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion
from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
        port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
        ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'webrtc::PortAllocatorFactoryInterface *' for 1st argument
  scoped_refptr(T* p) : ptr_(p) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const
scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
  scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template
ignored: could not match 'scoped_refptr' against 'scoped_ptr'
  scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
  ^
../../base/memory/scoped_ptr.h:378:3: note: candidate function
  operator Testable() const {
  ^
1 error generated.

From
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

Original issue's description:
> Removing references to webrtc::PortAllocatorFactoryInterface.
> 
> Now using a new CreatePeerConnection method that takes a
> PortAllocator as input. This removes the need for some
> boilerplate code and code duplication between webrtc and chromium.
> It also fixes an issue with TURN candidate priorities.
> 
> BUG=webrtc:5209
> 
> Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
> Cr-Commit-Position: refs/heads/master@{#364544}

TBR=sergeyu@chromium.org,deadbeef@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5209
==========

to

==========
Revert of Removing references to webrtc::PortAllocatorFactoryInterface.
(patchset #6 id:100001 of https://codereview.chromium.org/1500663003/ )

Reason for revert:
Broke the build:

../../remoting/host/remoting_me2me_host.cc:1505:9: error: no viable conversion
from 'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'rtc::scoped_refptr<webrtc::PortAllocatorFactoryInterface>'
        port_allocator_factory = protocol::ChromiumPortAllocatorFactory::Create(
        ^                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/base/scoped_ref_ptr.h:76:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to
'webrtc::PortAllocatorFactoryInterface *' for 1st argument
  scoped_refptr(T* p) : ptr_(p) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:81:3: note: candidate constructor
not viable: no known conversion from
'scoped_ptr<remoting::protocol::PortAllocatorFactory>' to 'const
scoped_refptr<webrtc::PortAllocatorFactoryInterface> &' for 1st argument
  scoped_refptr(const scoped_refptr<T>& r) : ptr_(r.ptr_) {
  ^
../../third_party/webrtc/base/scoped_ref_ptr.h:87:3: note: candidate template
ignored: could not match 'scoped_refptr' against 'scoped_ptr'
  scoped_refptr(const scoped_refptr<U>& r) : ptr_(r.get()) {
  ^
../../base/memory/scoped_ptr.h:378:3: note: candidate function
  operator Testable() const {
  ^
1 error generated.

From
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

Original issue's description:
> Removing references to webrtc::PortAllocatorFactoryInterface.
>
> Now using a new CreatePeerConnection method that takes a
> PortAllocator as input. This removes the need for some
> boilerplate code and code duplication between webrtc and chromium.
> It also fixes an issue with TURN candidate priorities.
>
> BUG=webrtc:5209
>
> Committed: https://crrev.com/ad868b5edf13e869e835b847078b4dcc8aa7cd0d
> Cr-Commit-Position: refs/heads/master@{#364544}

TBR=sergeyu@chromium.org,deadbeef@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5209

Committed: https://crrev.com/ed698a70b951776aac2af82e3d7c73c6d201e1b8
Cr-Commit-Position: refs/heads/master@{#364556}
==========

[commit-bot: I haz the power, 2015-12-11 01:17:12]

Patchset 1 (id:??) landed as
https://crrev.com/ed698a70b951776aac2af82e3d7c73c6d201e1b8
Cr-Commit-Position: refs/heads/master@{#364556}