Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1500423002: Remove redundant code from v8_interface.py (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
haraken, philipj_slow
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant code from v8_interface.py The 'UseCounter.h' include is added when needed by deprecate_as and measure_as methods. BUG=567015 Committed: https://crrev.com/07fa29e8c3a6c6527b12907ea6b48e2798710f53 Cr-Commit-Position: refs/heads/master@{#363449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500423002/1
5 years ago (2015-12-07 09:54:03 UTC) #2
davve
This part was added in ps#1 of https://codereview.chromium.org/103963003, removed with description "Simpler" in ps#2, but ...
5 years ago (2015-12-07 10:00:43 UTC) #5
haraken
LGTM
5 years ago (2015-12-07 10:02:29 UTC) #6
philipj_slow
lgtm
5 years ago (2015-12-07 10:51:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500423002/1
5 years ago (2015-12-07 10:54:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 11:12:10 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-07 11:12:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07fa29e8c3a6c6527b12907ea6b48e2798710f53
Cr-Commit-Position: refs/heads/master@{#363449}

Powered by Google App Engine
This is Rietveld 408576698