Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1500423002: Remove redundant code from v8_interface.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # coding=utf-8 2 # coding=utf-8
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 if is_check_security: 119 if is_check_security:
120 includes.add('bindings/core/v8/BindingSecurity.h') 120 includes.add('bindings/core/v8/BindingSecurity.h')
121 121
122 # [DependentLifetime] 122 # [DependentLifetime]
123 is_dependent_lifetime = 'DependentLifetime' in extended_attributes 123 is_dependent_lifetime = 'DependentLifetime' in extended_attributes
124 124
125 # [PrimaryGlobal] and [Global] 125 # [PrimaryGlobal] and [Global]
126 is_global = ('PrimaryGlobal' in extended_attributes or 126 is_global = ('PrimaryGlobal' in extended_attributes or
127 'Global' in extended_attributes) 127 'Global' in extended_attributes)
128 128
129 # [MeasureAs]
130 is_measure_as = 'MeasureAs' in extended_attributes
131 if is_measure_as:
132 includes.add('core/frame/UseCounter.h')
133
134 # [SetWrapperReferenceFrom] 129 # [SetWrapperReferenceFrom]
135 set_wrapper_reference_from = extended_attributes.get('SetWrapperReferenceFro m') 130 set_wrapper_reference_from = extended_attributes.get('SetWrapperReferenceFro m')
136 if set_wrapper_reference_from: 131 if set_wrapper_reference_from:
137 includes.update(['bindings/core/v8/V8GCController.h', 132 includes.update(['bindings/core/v8/V8GCController.h',
138 'core/dom/Element.h']) 133 'core/dom/Element.h'])
139 134
140 # [SetWrapperReferenceTo] 135 # [SetWrapperReferenceTo]
141 set_wrapper_reference_to_argument = extended_attributes.get('SetWrapperRefer enceTo') 136 set_wrapper_reference_to_argument = extended_attributes.get('SetWrapperRefer enceTo')
142 set_wrapper_reference_to = None 137 set_wrapper_reference_to = None
143 if set_wrapper_reference_to_argument: 138 if set_wrapper_reference_to_argument:
(...skipping 1243 matching lines...) Expand 10 before | Expand all | Expand 10 after
1387 1382
1388 extended_attributes = deleter.extended_attributes 1383 extended_attributes = deleter.extended_attributes
1389 idl_type = deleter.idl_type 1384 idl_type = deleter.idl_type
1390 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState') 1385 is_call_with_script_state = v8_utilities.has_extended_attribute_value(delete r, 'CallWith', 'ScriptState')
1391 return { 1386 return {
1392 'is_call_with_script_state': is_call_with_script_state, 1387 'is_call_with_script_state': is_call_with_script_state,
1393 'is_custom': 'Custom' in extended_attributes, 1388 'is_custom': 'Custom' in extended_attributes,
1394 'is_raises_exception': 'RaisesException' in extended_attributes, 1389 'is_raises_exception': 'RaisesException' in extended_attributes,
1395 'name': cpp_name(deleter), 1390 'name': cpp_name(deleter),
1396 } 1391 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698