Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 103963003: IDL compiler: [MeasureAs] interfaces (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [MeasureAs] interfaces BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163385

Patch Set 1 #

Patch Set 2 : Simpler #

Patch Set 3 : Better test #

Patch Set 4 : Better test (reupload) #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/bindings/scripts/unstable/v8_interface.py View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceConstructor.idl View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-06 07:11:21 UTC) #1
haraken
LGTM
7 years ago (2013-12-06 07:11:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/103963003/80001
7 years ago (2013-12-09 01:45:27 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 01:45:39 UTC) #4
Message was sent while issue was closed.
Change committed as 163385

Powered by Google App Engine
This is Rietveld 408576698