Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 149953003: Revert 247793 "Ensure GL initialization only happens once, and p..." (Closed)

Created:
6 years, 10 months ago by Yoyo Zhou
Modified:
6 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 247793 "Ensure GL initialization only happens once, and p..." due to new static initializers in gl_bindings_autogen_gl.cc > Ensure GL initialization only happens once, and provide common init path > > Currently tests initialize GL by calling into methods that should be > internal to the gl bindings code. Instead, everyone should go through > GLSurface::InitializeOneOff. > > Also GLSurface::InitializeOneOff early outs if it was already called, > leading to a pattern of initializing GL all over the place just in case > and not having a clear idea of where it should be set up. Instead, DCHECK > that it is not called more than once, and move calls to this method to > be during process startup for unit test suites instead of mid-test. > > This adds two test variants of InitializeOneOff for tests to call, that > set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff. > > R=piman, sievers > BUG=270918 > > Review URL: https://codereview.chromium.org/135213003 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -230 lines) Patch
M trunk/src/cc/test/cc_test_suite.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/cc/test/layer_tree_pixel_test.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M trunk/src/cc/test/pixel_test.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/content/browser/browser_main_loop.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/gpu/gpu_child_thread.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M trunk/src/content/gpu/gpu_main.cc View 1 chunk +1 line, -18 lines 0 comments Download
M trunk/src/content/test/content_test_suite.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/gpu/command_buffer/common/unittest_main.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/gpu/config/gpu_info_collector.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/gpu/config/gpu_info_collector_android.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M trunk/src/gpu/config/gpu_info_collector_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/gpu/tools/compositor_model_bench/compositor_model_bench.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/media/tools/player_x11/gl_video_renderer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ui/aura/bench/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/aura/bench/bench_main.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D trunk/src/ui/aura/demo/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/aura/demo/demo_main.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/ui/compositor/test/context_factories_for_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ui/compositor/test/default_context_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ui/compositor/test/default_context_factory.cc View 1 chunk +9 lines, -1 line 0 comments Download
M trunk/src/ui/compositor/test/test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/gl/gl_bindings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/ui/gl/gl_gl_api_implementation.cc View 1 chunk +1 line, -18 lines 0 comments Download
M trunk/src/ui/gl/gl_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/gl/gl_implementation_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/gl/gl_implementation_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/gl/gl_implementation_ozone.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/gl/gl_implementation_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/gl/gl_implementation_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/ui/gl/gl_surface.h View 3 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/ui/gl/gl_surface.cc View 4 chunks +10 lines, -78 lines 0 comments Download
M trunk/src/ui/gl/gl_surface_egl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M trunk/src/ui/keyboard/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/keyboard/test/run_all_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/ui/views/examples/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/views/examples/examples_main.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 3 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yoyo Zhou
6 years, 10 months ago (2014-01-30 02:04:56 UTC) #1
Yoyo Zhou
6 years, 10 months ago (2014-01-30 02:06:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r247811 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698