Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: trunk/src/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

Issue 149953003: Revert 247793 "Ensure GL initialization only happens once, and p..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ui/views/examples/examples_main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
===================================================================
--- trunk/src/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (revision 247809)
+++ trunk/src/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (working copy)
@@ -24,7 +24,7 @@
#include "gpu/command_buffer/client/gles2_lib.h"
#include "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
#include "ui/gfx/size.h"
-#include "ui/gl/gl_implementation.h"
+#include "ui/gl/gl_surface.h"
using gpu::gles2::GLES2Implementation;
using gpu::GLInProcessContext;
@@ -74,9 +74,12 @@
WebGraphicsContext3DInProcessCommandBufferImpl::CreateViewContext(
const blink::WebGraphicsContext3D::Attributes& attributes,
gfx::AcceleratedWidget window) {
- DCHECK_NE(gfx::GetGLImplementation(), gfx::kGLImplementationNone);
- return make_scoped_ptr(new WebGraphicsContext3DInProcessCommandBufferImpl(
+ scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl> context;
+ if (gfx::GLSurface::InitializeOneOff()) {
+ context.reset(new WebGraphicsContext3DInProcessCommandBufferImpl(
scoped_ptr< ::gpu::GLInProcessContext>(), attributes, false, window));
+ }
+ return context.Pass();
}
// static
@@ -84,21 +87,24 @@
WebGraphicsContext3DInProcessCommandBufferImpl::CreateOffscreenContext(
const blink::WebGraphicsContext3D::Attributes& attributes) {
return make_scoped_ptr(new WebGraphicsContext3DInProcessCommandBufferImpl(
- scoped_ptr< ::gpu::GLInProcessContext>(),
- attributes,
- true,
- gfx::kNullAcceleratedWidget));
+ scoped_ptr< ::gpu::GLInProcessContext>(),
+ attributes,
+ true,
+ gfx::kNullAcceleratedWidget))
+ .Pass();
}
scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>
WebGraphicsContext3DInProcessCommandBufferImpl::WrapContext(
scoped_ptr< ::gpu::GLInProcessContext> context,
const blink::WebGraphicsContext3D::Attributes& attributes) {
- return make_scoped_ptr(new WebGraphicsContext3DInProcessCommandBufferImpl(
- context.Pass(),
- attributes,
- true /* is_offscreen. Not used. */,
- gfx::kNullAcceleratedWidget /* window. Not used. */));
+ return make_scoped_ptr(
+ new WebGraphicsContext3DInProcessCommandBufferImpl(
+ context.Pass(),
+ attributes,
+ true /* is_offscreen. Not used. */,
+ gfx::kNullAcceleratedWidget /* window. Not used. */))
+ .Pass();
}
WebGraphicsContext3DInProcessCommandBufferImpl::
« no previous file with comments | « trunk/src/ui/views/examples/examples_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698