Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2328)

Unified Diff: base/sys_info_unittest.cc

Issue 1498003003: Remove kint64max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: INT64_MAX Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/sys_info_posix.cc ('k') | base/sys_info_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_unittest.cc
diff --git a/base/sys_info_unittest.cc b/base/sys_info_unittest.cc
index 127d93055aa37a07e3869e53599787a292f9be4e..2a542262d6bb9f7f4d9c2b502ee1b5f742e235a0 100644
--- a/base/sys_info_unittest.cc
+++ b/base/sys_info_unittest.cc
@@ -43,9 +43,9 @@ TEST_F(SysInfoTest, AmountOfFreeDiskSpace) {
#if defined(OS_WIN) || defined(OS_MACOSX)
TEST_F(SysInfoTest, OperatingSystemVersionNumbers) {
- int32 os_major_version = -1;
- int32 os_minor_version = -1;
- int32 os_bugfix_version = -1;
+ int32_t os_major_version = -1;
+ int32_t os_minor_version = -1;
+ int32_t os_bugfix_version = -1;
base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
&os_minor_version,
&os_bugfix_version);
@@ -75,9 +75,9 @@ TEST_F(SysInfoTest, HardwareModelName) {
#if defined(OS_CHROMEOS)
TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {
- int32 os_major_version = -1;
- int32 os_minor_version = -1;
- int32 os_bugfix_version = -1;
+ int32_t os_major_version = -1;
+ int32_t os_minor_version = -1;
+ int32_t os_bugfix_version = -1;
const char kLsbRelease[] =
"FOO=1234123.34.5\n"
"CHROMEOS_RELEASE_VERSION=1.2.3.4\n";
@@ -91,9 +91,9 @@ TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {
}
TEST_F(SysInfoTest, GoogleChromeOSVersionNumbersFirst) {
- int32 os_major_version = -1;
- int32 os_minor_version = -1;
- int32 os_bugfix_version = -1;
+ int32_t os_major_version = -1;
+ int32_t os_minor_version = -1;
+ int32_t os_bugfix_version = -1;
const char kLsbRelease[] =
"CHROMEOS_RELEASE_VERSION=1.2.3.4\n"
"FOO=1234123.34.5\n";
@@ -107,9 +107,9 @@ TEST_F(SysInfoTest, GoogleChromeOSVersionNumbersFirst) {
}
TEST_F(SysInfoTest, GoogleChromeOSNoVersionNumbers) {
- int32 os_major_version = -1;
- int32 os_minor_version = -1;
- int32 os_bugfix_version = -1;
+ int32_t os_major_version = -1;
+ int32_t os_minor_version = -1;
+ int32_t os_bugfix_version = -1;
const char kLsbRelease[] = "FOO=1234123.34.5\n";
base::SysInfo::SetChromeOSVersionInfoForTest(kLsbRelease, base::Time());
base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
« no previous file with comments | « base/sys_info_posix.cc ('k') | base/sys_info_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698