Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1497743004: Remove run_pie from android/tools now that ICS support is deprecated (Closed)

Created:
5 years ago by pkotwicz
Modified:
5 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove run_pie from android/tools now that ICS support is deprecated BUG=473837, 535071 Committed: https://crrev.com/bf76930aa62c84995ba84327173b1542b83186f3 Cr-Commit-Position: refs/heads/master@{#363272}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -127 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/android/android_tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/run_pie/run_pie.c View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/android/run_pie/run_pie.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D tools/telemetry/bin/android/arm64-v8a/run_pie.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/android/armeabi-v7a/run_pie.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_platform_backend.py View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 20 (7 generated)
pkotwicz
primiano@ PTAL
5 years ago (2015-12-04 03:40:24 UTC) #2
pkotwicz
Hold up, I am not ready for code review yet. I am going through the ...
5 years ago (2015-12-04 03:49:40 UTC) #3
pkotwicz
All's good to go. primiano@ can you please take a look?
5 years ago (2015-12-04 04:59:38 UTC) #5
Primiano Tucci (use gerrit)
Oh many thanks for cleaning this up. Can you also remove: the various run_pie.sha1 in ...
5 years ago (2015-12-04 10:15:54 UTC) #6
pkotwicz
jbudorick@ for build/ nednguyen@ for tools/telemetry yfriedman@ for tools/android I have checked and the changes ...
5 years ago (2015-12-04 16:04:20 UTC) #8
nednguyen
what does the run_pie tool do? https://codereview.chromium.org/1497743004/diff/40001/tools/telemetry/telemetry/internal/platform/android_platform_backend.py File tools/telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/1497743004/diff/40001/tools/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode62 tools/telemetry/telemetry/internal/platform/android_platform_backend.py:62: def _SetupPrebuiltTools(device): Kari: ...
5 years ago (2015-12-04 16:07:20 UTC) #10
jbudorick
build/ lgtm
5 years ago (2015-12-04 16:09:01 UTC) #11
Yaron
lgtm
5 years ago (2015-12-04 16:10:51 UTC) #12
pkotwicz
nednguyen@ http://crbug.com/373219 provides a good summary of what the run_pie tool does. https://codereview.chromium.org/287513002 is the ...
5 years ago (2015-12-04 17:05:24 UTC) #13
nednguyen
Thanks for the context. lgtm
5 years ago (2015-12-04 17:14:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497743004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497743004/40001
5 years ago (2015-12-04 18:24:00 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-04 19:51:12 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-04 19:52:11 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf76930aa62c84995ba84327173b1542b83186f3
Cr-Commit-Position: refs/heads/master@{#363272}

Powered by Google App Engine
This is Rietveld 408576698