[Android] Build android tools as PIE and add a wrapper for ICS

[Android] Build android tools as PIE and add a wrapper for ICS

- Make Android tools build as position independent executable by
  default, as it now required by Android.
- Introduce a wrapper for running PIE on Android ICS (its linker
  doesn't support PIE).
- Add the plumbing for running the PIE wrapper in the test/telemetry
  python scripts.

BUG=373219
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270406

[Primiano Tucci (use gerrit), 2014-05-14 12:02:16]

Torne: can you PTAL to the gyp changes and the run_pie.c ?
Bulach: can you PTAL to the py changes?

[Torne, 2014-05-14 12:47:43]

This is gross but probably the easiest way to work around this for now :/

LGTM

[bulach, 2014-05-14 12:57:04]

lgtm, thanks! 
+jbudorick for build/android, dominikg for tools/telemetry

just nits below:

https://codereview.chromium.org/287513002/diff/120001/build/android/provision...
File build/android/provision_devices.py (left):

https://codereview.chromium.org/287513002/diff/120001/build/android/provision...
build/android/provision_devices.py:67: # TODO(jbudorick) Try to convert this to
RunShellCommand.
hmm... looks like there was some problems with RunShellCommand, I think it
throws exception should the underlying thing blow up?
john?

https://codereview.chromium.org/287513002/diff/120001/build/android/pylib/and...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/287513002/diff/120001/build/android/pylib/and...
build/android/pylib/android_commands.py:660: lib path (for content builds), (2)
using the PIE wrapper wrapper on ICS.
what's "content builds" ?

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
File tools/android/run_pie/run_pie.c (right):

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:5: */
nit: I think we use // instead of multiline comment?
ditto for all comments below.

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:24: int main(int argc, char** argv)
nit: { on this line

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:39: memcpy(argv[i-1], argv[i], argv_len);
nit: s/i-1/i - 1/

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
File tools/android/run_pie/run_pie.gyp (right):

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.gyp:13: # Of course, run_pie is the only Android
executable which must be NON-PIE.
nit: be kind on our future selves!
s/Of course/See crbug.com/foobar/ :)

[Primiano Tucci (use gerrit), 2014-05-14 13:21:22]

Thanks!
I know the run_pie thing is not the cleanest thing I wrote, but at least is
self-contained and makes the rest of non-ICS platforms pretty much unaware of
this change.

https://codereview.chromium.org/287513002/diff/120001/build/android/pylib/and...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/287513002/diff/120001/build/android/pylib/and...
build/android/pylib/android_commands.py:660: lib path (for content builds), (2)
using the PIE wrapper wrapper on ICS.
On 2014/05/14 12:57:05, bulach wrote:
> what's "content builds" ?

OMG, I meant "component" :)
Fixed.

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
File tools/android/run_pie/run_pie.c (right):

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:5: */
On 2014/05/14 12:57:05, bulach wrote:
> nit: I think we use // instead of multiline comment?
> ditto for all comments below.

OMG, you're asking me to be non ANSI-C compliant? :P
(Ok just because these days not even string.h is ANSI compliant anymore :D)
Done.

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:24: int main(int argc, char** argv)
On 2014/05/14 12:57:05, bulach wrote:
> nit: { on this line

Done.

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.c:39: memcpy(argv[i-1], argv[i], argv_len);
On 2014/05/14 12:57:05, bulach wrote:
> nit: s/i-1/i - 1/

Done.

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
File tools/android/run_pie/run_pie.gyp (right):

https://codereview.chromium.org/287513002/diff/120001/tools/android/run_pie/r...
tools/android/run_pie/run_pie.gyp:13: # Of course, run_pie is the only Android
executable which must be NON-PIE.
On 2014/05/14 12:57:05, bulach wrote:
> nit: be kind on our future selves!
> s/Of course/See crbug.com/foobar/ :)

Done.

[Dominik Grewe, 2014-05-14 13:57:53]

tools/telemetry lgtm

https://codereview.chromium.org/287513002/diff/160001/build/android/pylib/and...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/287513002/diff/160001/build/android/pylib/and...
build/android/pylib/android_commands.py:660: lib path (for
component=shared_library), (2) using the PIE wrapper wrapper
nit: "PIE wrapper wrapper"?

[jbudorick, 2014-05-14 14:10:04]

build/android/ lgtm

[Primiano Tucci (use gerrit), 2014-05-14 14:23:39]

Thanks all for the review.

Adding NOTRY since the trybots went already green (and there were just nits
afterwards) and I expect bigger troubles on the actual bots.

Keep calm and watch the bots!

https://codereview.chromium.org/287513002/diff/160001/build/android/pylib/and...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/287513002/diff/160001/build/android/pylib/and...
build/android/pylib/android_commands.py:660: lib path (for
component=shared_library), (2) using the PIE wrapper wrapper
On 2014/05/14 13:57:54, Dominik Grewe wrote:
> nit: "PIE wrapper wrapper"?

Essentially, a burrito :P

[Primiano Tucci (use gerrit), 2014-05-14 15:13:46]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2014-05-14 15:13:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/primiano@chromium.org/287513002/210001

[commit-bot: I haz the power, 2014-05-14 15:15:21]

Change committed as 270406

[trongbangvp, 2014-11-28 02:50:00]

On 2014/05/14 15:15:21, I haz the power (commit-bot) wrote:
> Change committed as 270406

Hi every one!
I cannot use run-pie.c for my project that used a executable.
I compile run-pie.c with android NDK for android-10 but it crash when i run on
android 3.0.
Could any one help ?

[Primiano Tucci (use gerrit), 2014-11-28 09:04:00]

On 2014/11/28 02:50:00, trongbangvp wrote:
> On 2014/05/14 15:15:21, I haz the power (commit-bot) wrote:
> > Change committed as 270406
> 
> Hi every one!
> I cannot use run-pie.c for my project that used a executable.
> I compile run-pie.c with android NDK for android-10 but it crash when i run on
> android 3.0.
> Could any one help ?

Not sure what is your problem here. Are you trying to compile run_pie.c
manually? That is tricky. You need to NOT compile it with neither -fPIE nor
-fpie and you have to take out also the stlport library.
Instead, the binaries that you plan to wrap (i.e. to pass as argument of
run_pie) MUST be compiled with -fPIE -fvisibility=default and linked with -pie
-rdynamic