build/common.gypi - Issue 1497743004: Remove run_pie from android/tools now that ICS support is deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1497743004: Remove run_pie from android/tools now that ICS support is deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 0974b49752e64eb3aaa4cd9c89bc79f6fbaeb110..e0e4dc9b2445babf2dd6dfe7dda35ad73875069a 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4955,20 +4955,14 @@

'target_conditions': [

['_type=="executable"', {

- # Force android tools to export the "main" symbol so they can be

- # loaded on ICS using the run_pie wrapper. See crbug.com/373219.

- # TODO(primiano): remove -fvisibility and -rdynamic flags below

- # when ICS support will be dropped.

'cflags': [

'-fPIE',

- '-fvisibility=default',

'ldflags': [

'-Bdynamic',

'-Wl,--gc-sections',

'-Wl,-z,nocopyreloc',

'-pie',

- '-rdynamic',

# crtbegin_dynamic.o should be the last item in ldflags.

'<(android_ndk_lib)/crtbegin_dynamic.o',

« no previous file with comments | « no previous file | tools/android/android_tools.gyp » ('j') | tools/telemetry/telemetry/internal/platform/android_platform_backend.py » ('J')