Skip dm GPU configs when context creation fails

Skip dm GPU configs when context creation fails

Skip dm GPU configs when context creation fails instead of stopping
the whole dm run.

Committed: https://skia.googlesource.com/skia/+/a18a8bca24f8b927c360e36f23d2fd08c6378805

[Kimmo Kinnunen, 2015-12-03 12:25:17]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com, mtklein@google.com

[Kimmo Kinnunen, 2015-12-03 12:25:17]

Came up in other review.


On 2015/12/02 14:30:28, bsalomon wrote:
>
https://codereview.chromium.org/1448883002/diff/80001/src/gpu/GrContextFactor...
> File src/gpu/GrContextFactory.cpp (left):
> 
>
https://codereview.chromium.org/1448883002/diff/80001/src/gpu/GrContextFactor...
> src/gpu/GrContextFactory.cpp:102: GrGpu* gpu = grCtx->getGpu();
> On 2015/12/02 14:03:57, Kimmo Kinnunen wrote:
> > IIRC this hunk was interesting when NVPR was run by default. DM would quit
if
> > NVPR was not supported and this would return nullptr.
> > 
> > Now it can return nullptr because nvpr is used only when --config nvprmsaa*
is
> > passed, and in this case DM quitting should be desirable?
> 
> Does DM really fail or does it just print that it won't run the config? I
think
> we'd prefer the latter.
>

[bsalomon, 2015-12-03 14:27:34]

lgtm

[Kimmo Kinnunen, 2015-12-04 06:50:18]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-12-04 06:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497713002/1

[commit-bot: I haz the power, 2015-12-04 07:04:53]

Description was changed from

==========
Skip dm GPU configs when context creation fails

Skip dm GPU configs when context creation fails instead of stopping
the whole dm run.
==========

to

==========
Skip dm GPU configs when context creation fails

Skip dm GPU configs when context creation fails instead of stopping
the whole dm run.

Committed:
https://skia.googlesource.com/skia/+/a18a8bca24f8b927c360e36f23d2fd08c6378805
==========

[commit-bot: I haz the power, 2015-12-04 07:04:53]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a18a8bca24f8b927c360e36f23d2fd08c6378805