Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: src/gpu/GrContextFactory.cpp

Issue 1497713002: Skip dm GPU configs when context creation fails (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | tests/GLInterfaceValidationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrContextFactory.cpp
diff --git a/src/gpu/GrContextFactory.cpp b/src/gpu/GrContextFactory.cpp
index 424b3fda3a86b6047ee45d4fbe94ca056b86a3ff..097b99b0b75f50e5082e0a66ac93635feecea5fe 100755
--- a/src/gpu/GrContextFactory.cpp
+++ b/src/gpu/GrContextFactory.cpp
@@ -80,10 +80,6 @@ GrContextFactory::ContextInfo* GrContextFactory::getContextInfo(GLContextType ty
if (!glInterface) {
return nullptr;
}
- } else {
- if (!glInterface->hasExtension("GL_NV_path_rendering")) {
- return nullptr;
- }
}
glCtx->makeCurrent();
@@ -96,22 +92,9 @@ GrContextFactory::ContextInfo* GrContextFactory::getContextInfo(GLContextType ty
if (!grCtx.get()) {
return nullptr;
}
- // Warn if path rendering support is not available for the NVPR type.
if (kNVPR_GLContextType == type) {
if (!grCtx->caps()->shaderCaps()->pathRenderingSupport()) {
- GrGpu* gpu = grCtx->getGpu();
- const GrGLContext* ctx = gpu->glContextForTesting();
- if (ctx) {
- const GrGLubyte* verUByte;
- GR_GL_CALL_RET(ctx->interface(), verUByte, GetString(GR_GL_VERSION));
- const char* ver = reinterpret_cast<const char*>(verUByte);
- SkDebugf("\nWARNING: nvprmsaa config requested, but driver path rendering "
- "support not available. Maybe update the driver? Your driver version "
- "string: \"%s\"\n", ver);
- } else {
- SkDebugf("\nWARNING: nvprmsaa config requested, but driver path rendering "
- "support not available.\n");
- }
+ return nullptr;
}
}
« no previous file with comments | « dm/DM.cpp ('k') | tests/GLInterfaceValidationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698