Remove an overloaded strokeRect in <canvas>

Remove an overloaded strokeRect in <canvas>

The canvas spec [1] does not define strokeRect with 5 arguments, so this issue
remains only strokeRect with 4 arguments.

[1] http://www.w3.org/TR/2dcontext2/

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150200

[dshwang, 2013-05-10 12:21:35]

FF and Opera have only strokeRect with 4 arguments. I checked it using
fast/canvas/canvas-strokeRect.html

strokeRect with 5 arguments was created when <canvas> was introduced in WebKit. 
Author: darin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Mar 16 08:54:13 2006 +0000

    Oops, these files were supposed to go in.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13330
268f45cc-cd09-0410-ab3c-d52691b4dbfc

[dshwang, 2013-05-10 12:23:15]

Eric, do you think I need to send "intent to ship" mail? This change removes one
web api, but trivial.

[Stephen White, 2013-05-10 12:27:14]

https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
File LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt (left):

https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt:11: PASS
ctx.strokeRect(0, 0, 0, 0, 0) is undefined
This is the only test case that should fail, correct? I think we should leave
this test in, and remove this test case.

[dshwang, 2013-05-10 12:30:17]

On 2013/05/10 12:27:14, Stephen White wrote:
>
https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
> File LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt (left):
> 
>
https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
> LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt:11: PASS
> ctx.strokeRect(0, 0, 0, 0, 0) is undefined
> This is the only test case that should fail, correct? I think we should leave
> this test in, and remove this test case.

Thank you for review! aha, I forgot what I should say..

canvas/philip/tests/2d.missingargs.html can cover with
fast/canvas/canvas-overloads-strokeRect.html, so I removed it.
In addition, ctx.strokeRect(0, 0, 0, 0, 0) is also passed because Javascript can
receive more arguments than the number that the function defines.

[Stephen White, 2013-05-10 12:32:30]

On 2013/05/10 12:30:17, dshwang wrote:
> On 2013/05/10 12:27:14, Stephen White wrote:
> >
>
https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
> > File LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt
(left):
> > 
> >
>
https://codereview.chromium.org/14972014/diff/1/LayoutTests/fast/canvas/canva...
> > LayoutTests/fast/canvas/canvas-overloads-strokeRect-expected.txt:11: PASS
> > ctx.strokeRect(0, 0, 0, 0, 0) is undefined
> > This is the only test case that should fail, correct? I think we should
leave
> > this test in, and remove this test case.
> 
> Thank you for review! aha, I forgot what I should say..
> 
> canvas/philip/tests/2d.missingargs.html can cover with
> fast/canvas/canvas-overloads-strokeRect.html, so I removed it.
> In addition, ctx.strokeRect(0, 0, 0, 0, 0) is also passed because Javascript
can
> receive more arguments than the number that the function defines.

Ah, ok. This looks ok, but leaving for Eric to consider the compat implications.

[dshwang, 2013-05-10 12:34:28]

On 2013/05/10 12:32:30, Stephen White wrote:
> Ah, ok. This looks ok, but leaving for Eric to consider the compat
implications.

Thx! :)

[dshwang, 2013-05-13 05:29:16]

Hi! could you review please?

[eseidel, 2013-05-13 06:46:22]

lgtm

If we're the only engine to support this, then I believe this is a "trivial"
change and does not need an intent to ship.

Please consider lobbying WebKIt to remove this API as well.

[commit-bot: I haz the power, 2013-05-13 06:46:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/14972014/1

[commit-bot: I haz the power, 2013-05-13 07:45:12]

Change committed as 150200

[dshwang, 2013-05-13 09:09:40]

On 2013/05/13 06:46:22, Eric Seidel wrote:
> lgtm
> 
> If we're the only engine to support this, then I believe this is a "trivial"
> change and does not need an intent to ship.
> 
> Please consider lobbying WebKIt to remove this API as well.

Thanks! You always make very sense :)
I'll backport it to WebKit.

[dshwang, 2013-05-13 10:33:35]

I'm backporting it to WebKit at https://bugs.webkit.org/show_bug.cgi?id=116017