Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1496243005:
Use Window coordinates for IME composition bounds, auto resize (Closed)
|
Created:
5 years ago by oshima Modified:
5 years ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse Window coordinates for IME composition bounds, auto resize, pepper's selection bounds.
BUG=485650
TEST=covered by unit tests.
Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05
Cr-Commit-Position: refs/heads/master@{#364911}
Committed: https://crrev.com/33ec97cdafc23098dafaa8b643214f3dc62f65b8
Cr-Commit-Position: refs/heads/master@{#365072}
Patch Set 1 : #
Total comments: 4
Patch Set 2 : #
Total comments: 2
Patch Set 3 : #Patch Set 4 : removed NE condition because bounds can be same on mac. disable autoresize test on android #Patch Set 5 : #Patch Set 6 : adjusted test expectation #
Messages
Total messages: 67 (41 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Description was changed from ========== Use Window coordinates for IME cmopositino bounds, auto resize BUG=485650 ========== to ========== Use Window coordinates for IME composition bounds, auto resize BUG=485650 TEST=manual ==========
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize BUG=485650 TEST=manual ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=manual ==========
oshima@chromium.org changed reviewers: + piman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=manual ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. ==========
oshima@chromium.org changed reviewers: + avi@chromium.org, bokan@chromium.org - piman@chromium.org
bokan@ -> please review the coordinate conversion change. avi@ -> owners review
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/100001
lgtm https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... File content/renderer/render_view_impl.h (right): https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... content/renderer/render_view_impl.h:569: // FRIEND_TEST_ALL_PREFIXES(RenderViewImplScaleFactorTest, AutoResize); Uncomment? Or remove? https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... content/renderer/render_widget.cc:1718: WebRect window_rect = rect; So is window_rect in DIPs? i.e. window coordinates? Why is this TODO obsolete?
https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... File content/renderer/render_view_impl.h (right): https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... content/renderer/render_view_impl.h:569: // FRIEND_TEST_ALL_PREFIXES(RenderViewImplScaleFactorTest, AutoResize); On 2015/12/09 22:06:32, bokan wrote: > Uncomment? Or remove? Removed. Thank you for the catch! https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1496243005/diff/100001/content/renderer/rende... content/renderer/render_widget.cc:1718: WebRect window_rect = rect; On 2015/12/09 22:06:32, bokan wrote: > So is window_rect in DIPs? i.e. window coordinates? Why is this TODO obsolete? |rect| is screen coordinates and my comment was wrong. I changed the arg name to be more specific.
lgtm https://codereview.chromium.org/1496243005/diff/120001/content/renderer/rende... File content/renderer/render_view_browsertest.cc (right): https://codereview.chromium.org/1496243005/diff/120001/content/renderer/rende... content/renderer/render_view_browsertest.cc:391: } This override just to call the superclass version isn't needed.
https://codereview.chromium.org/1496243005/diff/120001/content/renderer/rende... File content/renderer/render_view_browsertest.cc (right): https://codereview.chromium.org/1496243005/diff/120001/content/renderer/rende... content/renderer/render_view_browsertest.cc:391: } On 2015/12/10 15:28:54, Avi wrote: > This override just to call the superclass version isn't needed. oops, thanks for the catch. done.
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org Link to the patchset: https://codereview.chromium.org/1496243005/#ps120001 (title: " ")
The CQ bit was unchecked by oshima@chromium.org
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/1496243005/#ps140001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
The CQ bit was unchecked by oshima@chromium.org
Patchset #4 (id:160001) has been deleted
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/1496243005/#ps180001 (title: "removed NE condition because bounds can be same on mac. disable autoresize test on android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/1496243005/#ps200001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/200001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/200001
Message was sent while issue was closed.
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. ==========
Message was sent while issue was closed.
Committed patchset #5 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:200001) has been created in https://codereview.chromium.org/1521853002/ by perkj@chromium.org. The reason for reverting is: Fails on http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/4247..
Message was sent while issue was closed.
Patchset #6 (id:220001) has been deleted
Message was sent while issue was closed.
On 2015/12/13 12:16:20, perkj wrote: > A revert of this CL (patchset #5 id:200001) has been created in > https://codereview.chromium.org/1521853002/ by mailto:perkj@chromium.org. > > The reason for reverting is: Fails on > http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/4247.. Adjusted test expectation to pass on mac 10.10 bot (The difference comes form the differene in font metrics).
Message was sent while issue was closed.
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ==========
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/1496243005/#ps240001 (title: "adjusted test expectation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496243005/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496243005/240001
Message was sent while issue was closed.
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} ========== to ========== Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. BUG=485650 TEST=covered by unit tests. Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 Cr-Commit-Position: refs/heads/master@{#364911} Committed: https://crrev.com/33ec97cdafc23098dafaa8b643214f3dc62f65b8 Cr-Commit-Position: refs/heads/master@{#365072} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/33ec97cdafc23098dafaa8b643214f3dc62f65b8 Cr-Commit-Position: refs/heads/master@{#365072} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
