content/renderer/render_view_impl.h - Issue 1496243005: Use Window coordinates for IME composition bounds, auto resize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 1496243005: Use Window coordinates for IME composition bounds, auto resize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjusted test expectation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 9a9d98688ea08783ad088bdc281acba758000c12..12ee60e35f6c8d02905a90f5b9364598064670d6 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -490,7 +490,7 @@ class CONTENT_EXPORT RenderViewImpl

void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) override;

void FocusChangeComplete() override;

void GetCompositionCharacterBounds(

- std::vector<gfx::Rect>* character_bounds) override;

+ std::vector<gfx::Rect>* character_bounds_in_window) override;

void GetCompositionRange(gfx::Range* range) override;

bool CanComposeInline() override;

void DidCommitCompositorFrame() override;

@@ -564,6 +564,8 @@ class CONTENT_EXPORT RenderViewImpl

FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, PaintAfterSwapOut);

FRIEND_TEST_ALL_PREFIXES(RenderViewImplScaleFactorTest,

ConverViewportToScreenWithZoomForDSF);

+ FRIEND_TEST_ALL_PREFIXES(RenderViewImplScaleFactorTest,

+ GetCompositionCharacterBoundsTest);

typedef std::map<GURL, double> HostZoomLevels;

« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »