Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(60)

Issue 1521853002: Revert of Use Window coordinates for IME composition bounds, auto resize (Closed)

Created:
3 years, 5 months ago by perkj_chrome
Modified:
3 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Window coordinates for IME composition bounds, auto resize (patchset #5 id:200001 of https://codereview.chromium.org/1496243005/ ) Reason for revert: Fails on http://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/4247. Original issue's description: > Use Window coordinates for IME composition bounds, auto resize, pepper's selection bounds. > > BUG=485650 > TEST=covered by unit tests. > > Committed: https://crrev.com/3d09c3fa33ff2d2a8fd85c9cc71f0faf1f3fbe05 > Cr-Commit-Position: refs/heads/master@{#364911} TBR=bokan@chromium.org,avi@chromium.org,oshima@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485650 Committed: https://crrev.com/e711a9018b0d54f4209d65cf43baee5b6ece1580 Cr-Commit-Position: refs/heads/master@{#364949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -146 lines) Patch
M content/renderer/render_view_browsertest.cc View 4 chunks +13 lines, -111 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +8 lines, -17 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
perkj_chrome
Created Revert of Use Window coordinates for IME composition bounds, auto resize
3 years, 5 months ago (2015-12-13 12:16:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521853002/1
3 years, 5 months ago (2015-12-13 12:16:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 5 months ago (2015-12-13 12:17:03 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2015-12-13 12:17:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e711a9018b0d54f4209d65cf43baee5b6ece1580
Cr-Commit-Position: refs/heads/master@{#364949}

Powered by Google App Engine
This is Rietveld 408576698