cc: Don't do CompositeAndReadback when using DelegatingRenderer.

cc: Don't do CompositeAndReadback when using DelegatingRenderer.

The renderer can't do a readback, so don't both to draw anything
for no reason. And return false to inform the caller than it
failed.

R=piman
BUG=123444
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199377

[piman, 2013-05-09 22:07:31]

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:967: }
else readback_request_on_impl_thread_->success = false.

Alternatively, and maybe better, we should make sure ReadbackRequest initializes
its fields...

[danakj, 2013-05-09 22:14:51]

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:967: }
On 2013/05/09 22:07:31, piman wrote:
> else readback_request_on_impl_thread_->success = false.
> 
> Alternatively, and maybe better, we should make sure ReadbackRequest
initializes
> its fields...

This is set on 961 just before the if, so that seems like enough?

[piman, 2013-05-09 22:18:04]

lgtm

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:967: }
On 2013/05/09 22:14:51, danakj wrote:
> On 2013/05/09 22:07:31, piman wrote:
> > else readback_request_on_impl_thread_->success = false.
> > 
> > Alternatively, and maybe better, we should make sure ReadbackRequest
> initializes
> > its fields...
> 
> This is set on 961 just before the if, so that seems like enough?

Oh, thanks... missed that.

[danakj, 2013-05-09 22:18:47]

Thanks!

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/14960006/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:967: }
On 2013/05/09 22:18:04, piman wrote:
> On 2013/05/09 22:14:51, danakj wrote:
> > On 2013/05/09 22:07:31, piman wrote:
> > > else readback_request_on_impl_thread_->success = false.
> > > 
> > > Alternatively, and maybe better, we should make sure ReadbackRequest
> > initializes
> > > its fields...
> > 
> > This is set on 961 just before the if, so that seems like enough?
> 
> Oh, thanks... missed that.

Np :) TBH I didn't see it first round and just thought draw_frame false was
enough :x

[commit-bot: I haz the power, 2013-05-09 22:19:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/14960006/1

[commit-bot: I haz the power, 2013-05-10 05:01:40]

Change committed as 199377