Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1495673002: Set v8_use_external_startup_data for GN Windows build. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set v8_use_external_startup_data for GN Windows build. This matches GYP. BUG=545641 R=dpranke@chromium.org Committed: https://crrev.com/62fbdbc1e9f7caaec0fb2248e95e150c65ffa812 Cr-Commit-Position: refs/heads/master@{#362804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M build_overrides/v8.gni View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
brettw
5 years ago (2015-12-02 19:28:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495673002/1
5 years ago (2015-12-02 19:29:44 UTC) #3
Dirk Pranke
lgtm
5 years ago (2015-12-02 19:48:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495673002/1
5 years ago (2015-12-02 20:06:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149002)
5 years ago (2015-12-02 20:31:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495673002/1
5 years ago (2015-12-02 20:53:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 22:03:34 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-02 22:08:22 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/62fbdbc1e9f7caaec0fb2248e95e150c65ffa812
Cr-Commit-Position: refs/heads/master@{#362804}

Powered by Google App Engine
This is Rietveld 408576698