build_overrides/v8.gni - Issue 1495673002: Set v8_use_external_startup_data for GN Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 1495673002: Set v8_use_external_startup_data for GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index b4b933b69247fea6e3ff3fd5bea57046c59da858..e50a6a2d894934d966ae997e87f45718dbb5a787 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -11,9 +11,8 @@ enable_correct_v8_arch = false

# TODO: Set v8_use_external_startup_data to true on Windows and iOS to match

# GYP.

-# Windows - http://crbug.com/545641

# iOS - http://crbug.com/545676

-v8_use_external_startup_data = !(is_win || is_ios)

+v8_use_external_startup_data = !is_ios

# V8 extras

# Adding V8 extras files requires API owners review

« no previous file with comments | « no previous file | chrome/installer/mini_installer/BUILD.gn » ('j') | no next file with comments »