Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7879)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 1495673002: Set v8_use_external_startup_data for GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index d04febf8904d743d6b85f5c56edea785d833df76..c205f8c22cf4956c548596105631638f4782b743 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -115,6 +115,16 @@ action("archive") {
#'--verbose',
]
+ deps = [
+ "//chrome",
+ "//chrome:main_dll",
+ "//chrome/browser/extensions/default_extensions",
+ "//chrome/installer/setup",
+ "//third_party/icu:icudata",
+
+ #"../chrome.gyp:chrome_nacl_win64", TODO(GYP) bug 512869.
+ ]
+
if (enable_hidpi) {
args += [ "--enable_hidpi=1" ]
}
@@ -145,6 +155,7 @@ action("archive") {
"$root_out_dir/natives_blob.bin",
"$root_out_dir/snapshot_blob.bin",
]
+ deps += [ "//v8" ]
}
depfile = "$target_gen_dir/archive.d"
@@ -153,16 +164,6 @@ action("archive") {
rebase_path(depfile, root_build_dir),
]
- deps = [
- "//chrome",
- "//chrome:main_dll",
- "//chrome/browser/extensions/default_extensions",
- "//chrome/installer/setup",
- "//third_party/icu:icudata",
-
- #"../chrome.gyp:chrome_nacl_win64", TODO(GYP) bug 512869.
- ]
-
if (enable_nacl) {
deps += [ "//ppapi/native_client:irt" ]
}
« no previous file with comments | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698