Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1494553002: Revert of Upgrade PixelStorei to ES3/WebGL2. (Closed)

Created:
5 years ago by Jamie Madill
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upgrade PixelStorei to ES3/WebGL2. (patchset #7 id:160001 of https://codereview.chromium.org/1474513003/ ) Reason for revert: Failing the WebGL 2 CTS: WebglConformance.conformance2_state_gl_get_calls: [3560:1299:1202/051124:INFO:CONSOLE(11)] "context.getParameter(context.UNPACK_SKIP_IMAGES) should be false (of type boolean). Was 0 (of type number).", source: (11) [3560:1299:1202/051124:INFO:CONSOLE(11)] "FAIL context.getParameter(context.UNPACK_SKIP_IMAGES) should be false (of type boolean). Was 0 (of type number).", source: (11) [3560:1299:1202/051124:INFO:CONSOLE(11)] "context.getParameter(context.UNPACK_SKIP_PIXELS) should be false (of type boolean). Was 0 (of type number).", source: (11) [3560:1299:1202/051124:INFO:CONSOLE(11)] "FAIL context.getParameter(context.UNPACK_SKIP_PIXELS) should be false (of type boolean). Was 0 (of type number).", source: (11) [3560:1299:1202/051124:INFO:CONSOLE(11)] "context.getParameter(context.UNPACK_SKIP_ROWS) should be false (of type boolean). Was 0 (of type number).", source: (11) [3560:1299:1202/051124:INFO:CONSOLE(11)] "FAIL context.getParameter(context.UNPACK_SKIP_ROWS) should be false (of type boolean). Was 0 (of type number).", source: (11) http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%20%28Intel%29/builds/7016 http://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Debug%20%28NVIDIA%29/builds/10350 http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/33475 Original issue's description: > Upgrade PixelStorei to ES3/WebGL2. > > BUG=295792, 429053 > TEST=gpu_unittests, webgl2_conformance > R=kbr@chromium.org,bajones@chromium.org,piman@chromium.org > > Committed: https://crrev.com/c6c114178c562feeddfc4d41a33b9999698a4144 > Cr-Commit-Position: refs/heads/master@{#362585} TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=295792, 429053 Committed: https://crrev.com/72ea7571631a1922f7c15e7ef5447b8098c1ab24 Cr-Commit-Position: refs/heads/master@{#362696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -711 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 9 chunks +6 lines, -77 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 6 chunks +20 lines, -61 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 4 chunks +0 lines, -38 lines 0 comments Download
M gpu/command_buffer/service/context_state_autogen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 5 chunks +0 lines, -168 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 7 chunks +23 lines, -100 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h View 2 chunks +1 line, -41 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 2 chunks +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 3 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 7 chunks +25 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 7 chunks +20 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie Madill
Created Revert of Upgrade PixelStorei to ES3/WebGL2.
5 years ago (2015-12-02 13:50:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494553002/1
5 years ago (2015-12-02 13:50:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 13:51:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72ea7571631a1922f7c15e7ef5447b8098c1ab24 Cr-Commit-Position: refs/heads/master@{#362696}
5 years ago (2015-12-02 13:52:53 UTC) #6
Zhenyao Mo
5 years ago (2015-12-02 17:32:51 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1492013002/ by zmo@chromium.org.

The reason for reverting is: revert the revert (i.e., reland)

the WebGL 2 CTS failure is due to the bug in the test.  I am going to suppress
it for now and fix it in khronos and roll in. .

Powered by Google App Engine
This is Rietveld 408576698