Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1494433005: Add RSB instruction to the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add RSB instruction to the ARM integrated assembler. Adds RSB (immediate) and RSB (register) to the ARM integrated assembler. Also moves udiv method to corresponding (sorted) position in cpp file. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=dca86741c89dbcb3fa7b77e9124a5985f04ee2d7

Patch Set 1 #

Patch Set 2 : Reformat and update Dart assembler files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -21 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 3 chunks +37 lines, -17 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/rsb.ll View 1 chunk +123 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
5 years ago (2015-12-04 16:16:04 UTC) #3
Jim Stichnoth
lgtm
5 years ago (2015-12-04 22:10:58 UTC) #4
Karl
5 years ago (2015-12-04 23:11:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dca86741c89dbcb3fa7b77e9124a5985f04ee2d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698