allocator cleanup: remove deprecated windows tc-malloc bits

allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because,
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
Committed: https://crrev.com/33a9814719fb7b0789a11310d96edc6a8fd941a1
Cr-Commit-Position: refs/heads/master@{#363459}

[Primiano Tucci (use gerrit), 2015-12-03 16:52:29]

Patchset #3 (id:40001) has been deleted

[Primiano Tucci (use gerrit), 2015-12-04 10:40:21]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

This CL is based on crrev.com/1489403002

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output.

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim) which is more restrictive than
    !shared_library.
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-04 10:40:21]

primiano@chromium.org changed reviewers:
+ thakis@chromium.org, wfh@chromium.org

[Primiano Tucci (use gerrit), 2015-12-04 10:41:16]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output.

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim) which is more restrictive than
    !shared_library.
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim) which is more restrictive than
    !shared_library.
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-04 10:42:24]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim) which is more restrictive than
    !shared_library.
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-04 10:46:12]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and rotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-04 10:46:59]

Patchset #1 (id:1) has been deleted

[Primiano Tucci (use gerrit), 2015-12-04 10:47:08]

Patchset #1 (id:20001) has been deleted

[Primiano Tucci (use gerrit), 2015-12-04 10:47:32]

PTAL, small follow up cleanup on windows for tcmalloc.
The ninja diff make sense to me, but I guess another couple of eyes on that
wouldn't be bad.

[Ruud van Asseldonk, 2015-12-04 17:25:36]

ruuda@google.com changed reviewers:
+ ruuda@google.com

[Ruud van Asseldonk, 2015-12-04 17:25:37]

https://codereview.chromium.org/1493893005/diff/80001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (left):

https://codereview.chromium.org/1493893005/diff/80001/base/allocator/BUILD.gn...
base/allocator/BUILD.gn:262: deps += [ ":prep_libc" ]
Why can this be removed?

[Primiano Tucci (use gerrit), 2015-12-04 17:40:21]

https://codereview.chromium.org/1493893005/diff/80001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (left):

https://codereview.chromium.org/1493893005/diff/80001/base/allocator/BUILD.gn...
base/allocator/BUILD.gn:262: deps += [ ":prep_libc" ]
On 2015/12/04 17:25:37, Ruud van Asseldonk wrote:
> Why can this be removed?

becuse tcmalloc is not supported on android anymore. so this is_win inside
tcmalloc should not exist at all.
(the useful prep_libc is in the allocator_shim part above on line 92)

[Primiano Tucci (use gerrit), 2015-12-04 17:44:06]

> becuse tcmalloc is not supported on android anymore. so this is_win inside

And when I say android I mean Windows (Stockholm syndrome I suppose)

[Primiano Tucci (use gerrit), 2015-12-04 18:08:36]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because that is just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Will Harris, 2015-12-05 03:36:07]

lgtm this change looks benign considering we have no tcmalloc on windows

What I'd really like to see is all the tcmalloc files being pulled out into a
separate target, but that could be done in a future CL.

[Nico, 2015-12-05 03:43:03]

lgtm2 fwiw

(typo "diffrence" in cl description)

[Primiano Tucci (use gerrit), 2015-12-07 10:08:08]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-12-07 10:08:08]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1493893005/#ps100001
(title: "Rebase after brettw changes in crrev.com/1499773002")

[Primiano Tucci (use gerrit), 2015-12-07 10:08:09]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-12-07 10:08:24]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The diffrence here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[Primiano Tucci (use gerrit), 2015-12-07 10:08:28]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2015-12-07 10:09:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493893005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493893005/100001

[commit-bot: I haz the power, 2015-12-07 11:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 11:04:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Primiano Tucci (use gerrit), 2015-12-07 11:08:00]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2015-12-07 11:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493893005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493893005/100001

[commit-bot: I haz the power, 2015-12-07 12:40:41]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

[commit-bot: I haz the power, 2015-12-07 12:40:42]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-12-07 12:41:24]

Description was changed from

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets 
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because, 
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.
  

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618
==========

to

==========
allocator cleanup: remove deprecated windows tc-malloc bits

use_allocator=tcmalloc is deprecated and bitrotten on Windows.
Cleaning up all the build files that refer to that.

I tested the CL on the following configurations and analyzed
the produced ninja output:

OS=win component=shared_library
OS=win GYP_MSVS_VERSION=2015 component=shared_library
0 ninja diff. This is expected, as in component builds
allocator was (and is) never pulled in.

OS=win
Diff: http://pastebin.com/PKaHJ3i2
The diffs here are:
  1. The -DPERFTOOLS_DLL_DECL flag disappearing from all the win targets
     that depend on allocator. This is an expected consequence of having
     removed the define here from the direct_dependent_settings.
  2. dynamic_annotations dep going away. that was just for tc-malloc.

OS=win GYP_MSVS_VERSION=2015
Diff: http://pastebin.com/nNDzETTV
The diffs here are:
 1. The allocator target becomes a no-op. This is intended because,
    according to common.gypi, the win_use_allocator_shim=0 for MSVS2015.
    The difference here is that previously the allocator target was
    built for MSVS2015 (because it was guarded only by !shared_library)
    but not depended on (because the depending guards looked at
    win_use_allocator_shim which is more restrictive than
    !shared_library).
 2. Some changes to allocator_unittest, which are irrelevant as
    allocator_unittest is being moved to base_unittest in
    crrev.com/1500733002.

OS=win clang=1 asan=1
Diff: http://pastebin.com/GkH10947
This is similar to the previous (OS=win GYP_MSVS_VERSION=2015) case.
In essence, when asan=1 the shim is force-disabled, so no targets end up
depending on allocator.gyp as they check for win_use_allocator_shim.
However, before this CL the allocator target was still being built,
because we were just looking at the more relaxed  !shared_library
condition.

BUG=564618

Committed: https://crrev.com/33a9814719fb7b0789a11310d96edc6a8fd941a1
Cr-Commit-Position: refs/heads/master@{#363459}
==========

[commit-bot: I haz the power, 2015-12-07 12:41:25]

Patchset 3 (id:??) landed as
https://crrev.com/33a9814719fb7b0789a11310d96edc6a8fd941a1
Cr-Commit-Position: refs/heads/master@{#363459}