allocator cleanup: remove deprecated windows tc-malloc bits

base/allocator/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/allocator.gni")
 
 declare_args() {
   # Provide a way to force disable debugallocation in Debug builds,
   # e.g. for profiling (it's more rare to profile Debug builds,
   # but people sometimes need to do that).
@@ skipping 208 matching lines @@
     ]
 
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [
       "//build/config/compiler:no_chromium_code",
       ":tcmalloc_flags",
     ]
 
     deps = []
 
-    if (is_win) {
-      sources -= [
-        "$tcmalloc_dir/src/base/elf_mem_image.cc",
-        "$tcmalloc_dir/src/base/elf_mem_image.h",
-        "$tcmalloc_dir/src/base/linuxthreads.cc",
-        "$tcmalloc_dir/src/base/linuxthreads.h",
-        "$tcmalloc_dir/src/base/vdso_support.cc",
-        "$tcmalloc_dir/src/base/vdso_support.h",
-        "$tcmalloc_dir/src/maybe_threads.cc",
-        "$tcmalloc_dir/src/maybe_threads.h",
-        "$tcmalloc_dir/src/symbolize.h",
-        "$tcmalloc_dir/src/system-alloc.cc",
-        "$tcmalloc_dir/src/system-alloc.h",
-
-        # cpuprofiler
-        "$tcmalloc_dir/src/base/thread_lister.c",
-        "$tcmalloc_dir/src/base/thread_lister.h",
-        "$tcmalloc_dir/src/profile-handler.cc",
-        "$tcmalloc_dir/src/profile-handler.h",
-        "$tcmalloc_dir/src/profiledata.cc",
-        "$tcmalloc_dir/src/profiledata.h",
-        "$tcmalloc_dir/src/profiler.cc",
-      ]
-      defines += [ "PERFTOOLS_DLL_DECL=" ]
-
-      configs -= [
-        # Tcmalloc defines this itself, and we don't want duplicate definition
-        # warnings.
-        "//build/config/win:nominmax",
-      ]
-
-      public_configs = [ ":nocmt" ]
-
-      deps += [ ":prep_libc" ]

[Ruud van Asseldonk, 2015/12/04 17:25:37]

Why can this be removed?

[Primiano Tucci (use gerrit), 2015/12/04 17:40:21]

becuse tcmalloc is not supported on android anymore. so this is_win inside
tcmalloc should not exist at all.
(the useful prep_libc is in the allocator_shim part above on line 92)

-    }
-
     if (is_linux || is_android) {
       sources -= [
         "$tcmalloc_dir/src/system-alloc.h",
         "$tcmalloc_dir/src/windows/port.cc",
         "$tcmalloc_dir/src/windows/port.h",
       ]
 
       # We enable all warnings by default, but upstream disables a few.
       # Keep "-Wno-*" flags in sync with upstream by comparing against:
       # http://code.google.com/p/google-perftools/source/browse/trunk/Makefile.am
@@ skipping 17 matching lines @@
     }
 
     # Make sure the allocation library is optimized as much as possible when
     # we"re in release mode.
     if (!is_debug) {
       configs -= [ "//build/config/compiler:default_optimization" ]
       configs += [ "//build/config/compiler:optimize_max" ]
     }
 
     deps += [ "//base/third_party/dynamic_annotations" ]
-
-    if (is_win) {
-      ldflags = [ "/ignore:4006:4221" ]
-    }
   }
 }  # !is_android
 
 source_set("extension_thunks") {
   visibility = [ "//base/*" ]
   sources = [
     "allocator_extension_thunks.cc",
     "allocator_extension_thunks.h",
   ]
   if (is_android && !is_debug) {
     configs -= [ "//build/config/compiler:default_optimization" ]
     configs += [ "//build/config/compiler:optimize_max" ]
   }
 }