Remove allocator_extension_thunks since this layer is not required

Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.

Committed: https://crrev.com/dda6c278fb665a69a6c4ef2d08f2a02b7f588f6b
Cr-Commit-Position: refs/heads/master@{#363497}

[Primiano Tucci (use gerrit), 2015-12-07 10:42:55]

Description was changed from

==========
Remove allocator_extension_thunks since this layer is not required

crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618

patch from issue 1487403002 at patchset 60001
(http://crrev.com/1487403002#ps60001)
==========

to

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org
Rebasing and landing on his behalf, ssid is OOO for the week.

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
==========

[Primiano Tucci (use gerrit), 2015-12-07 10:47:47]

Description was changed from

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org
Rebasing and landing on his behalf, ssid is OOO for the week.

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
==========

to

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.
==========

[Primiano Tucci (use gerrit), 2015-12-07 10:48:08]

primiano@chromium.org changed reviewers:
+ thakis@chromium.org, wfh@chromium.org

[Ruud van Asseldonk, 2015-12-07 15:27:13]

On 2015/12/07 10:48:08, Primiano Tucci wrote:
> mailto:primiano@chromium.org changed reviewers:
> + mailto:thakis@chromium.org, mailto:wfh@chromium.org

The rebase looks successful.

[Nico, 2015-12-07 15:30:47]

On 2015/12/07 15:27:13, Ruud van Asseldonk wrote:
> On 2015/12/07 10:48:08, Primiano Tucci wrote:
> > mailto:primiano@chromium.org changed reviewers:
> > + mailto:thakis@chromium.org, mailto:wfh@chromium.org
> 
> The rebase looks successful.

(am i supposed to review this? i got a "rebase looks successful" mail for this,
but nothing else. looks like https://codereview.chromium.org/1487403002 . if
ssid is cool with you landing this, then lgtm over here too)

[Primiano Tucci (use gerrit), 2015-12-07 16:05:53]

On 2015/12/07 15:30:47, Nico wrote:
> (am i supposed to review this? i got a "rebase looks successful" mail for
this,

Not really. This is just me rebasing a CL from ssid that you reviewed already. 
I just asked Ruud to sanity check my rebase and that caused the spam. You were
not supposed to see anything (probably just the landing email)

[Primiano Tucci (use gerrit), 2015-12-07 16:06:02]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2015-12-07 16:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505743002/20001

[commit-bot: I haz the power, 2015-12-07 16:51:13]

Description was changed from

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.
==========

to

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.
==========

[commit-bot: I haz the power, 2015-12-07 16:51:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 16:52:03]

Description was changed from

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.
==========

to

==========
Remove allocator_extension_thunks since this layer is not required

Original patch author: ssid@chromium.org

Original CL description:
crrev.com/10239012 added thunks target. There allocator_shim.cc wanted
to set function pointers when heap_init_() was called. To do this,
allocator_shim.cc (part of allocator target) used thunks to store the
functions without actually depending on thunks (relying on the fact
that base would finally link thunks). Since allocator_shim.cc included
thunks.h and allocator_unittests included allocator, but not base,
thunks target was introduced to avoid depending on base. Current
situation is that thunks is no longer used by the shim layer and not
used by allocator_unittests either (after shim was removed). Thunks was
left around for no reason. See design doc in the bug.

This CL removes the target and stores the functions in base.

BUG=564618
TBR=wfh@chromium.org,thakis@chromium.org
TBR Reason=the original patch was reviewed in crrev.com/1487403002.
           Just rebasing and landing it as ssid is OOO for one week.

Committed: https://crrev.com/dda6c278fb665a69a6c4ef2d08f2a02b7f588f6b
Cr-Commit-Position: refs/heads/master@{#363497}
==========

[commit-bot: I haz the power, 2015-12-07 16:52:04]

Patchset 2 (id:??) landed as
https://crrev.com/dda6c278fb665a69a6c4ef2d08f2a02b7f588f6b
Cr-Commit-Position: refs/heads/master@{#363497}