Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: tools/clang/plugins/tests/virtual_bodies.txt

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/virtual_bodies.txt
diff --git a/tools/clang/plugins/tests/virtual_bodies.txt b/tools/clang/plugins/tests/virtual_bodies.txt
index c58f98e9d332273df3276f7f7735125f906d121e..6d35751e0ba71ee540b872dfc9ae57045a5dd01e 100644
--- a/tools/clang/plugins/tests/virtual_bodies.txt
+++ b/tools/clang/plugins/tests/virtual_bodies.txt
@@ -1,5 +1,14 @@
In file included from virtual_bodies.cpp:5:
-./virtual_bodies.h:23:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline.
- virtual bool ComplainAboutThis() { return true; }
- ^
-1 warning generated.
+./virtual_bodies.h:17:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
+class InlineVirtualMethodsInHeaders {
+^
+./virtual_bodies.h:28:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
+class LongInlineVirtualMethods {
+^
+./virtual_bodies.h:83:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
+class InlineVirtualMethodsInLeafClass
+^
+./virtual_bodies.h:93:3: warning: [chromium-style] Complex destructor has an inline body.
+ ~DtorInlineVirtualMethodsInHeaders() {}
+ ^
+4 warnings generated.
« tools/clang/plugins/tests/virtual_bodies.h ('K') | « tools/clang/plugins/tests/virtual_bodies.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698