Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/clang/plugins/tests/virtual_bodies.txt

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 In file included from virtual_bodies.cpp:5: 1 In file included from virtual_bodies.cpp:5:
2 ./virtual_bodies.h:23:36: warning: [chromium-style] virtual methods with non-emp ty bodies shouldn't be declared inline. 2 ./virtual_bodies.h:17:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
3 virtual bool ComplainAboutThis() { return true; } 3 class InlineVirtualMethodsInHeaders {
4 ^ 4 ^
5 1 warning generated. 5 ./virtual_bodies.h:28:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
6 class LongInlineVirtualMethods {
7 ^
8 ./virtual_bodies.h:83:1: warning: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
9 class InlineVirtualMethodsInLeafClass
10 ^
11 ./virtual_bodies.h:93:3: warning: [chromium-style] Complex destructor has an inl ine body.
12 ~DtorInlineVirtualMethodsInHeaders() {}
13 ^
14 4 warnings generated.
OLDNEW
« tools/clang/plugins/tests/virtual_bodies.h ('K') | « tools/clang/plugins/tests/virtual_bodies.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698