Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: tools/clang/plugins/tests/virtual_bodies.cpp

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/virtual_bodies.cpp
diff --git a/tools/clang/plugins/tests/virtual_bodies.cpp b/tools/clang/plugins/tests/virtual_bodies.cpp
index 4f37a6786a45610cd60879214d24f4b0be4cebf8..f3da23aa5c27d101a55d54b105378cb55e7688cd 100644
--- a/tools/clang/plugins/tests/virtual_bodies.cpp
+++ b/tools/clang/plugins/tests/virtual_bodies.cpp
@@ -7,33 +7,10 @@
// Shouldn't warn about method usage in the implementation file.
class VirtualMethodsInImplementation {
public:
- virtual void MethodIsAbstract() = 0;
- virtual void MethodHasNoArguments();
- virtual void MethodHasEmptyDefaultImpl() {}
- virtual bool ComplainAboutThis() { return true; }
+ // Complain about the inline/missing constructor.
+ virtual void Method1() {}
+ virtual bool Method2() { return true; }
+ virtual void Method3() {}
+ virtual bool Method4() { return true; }
+ virtual void Method5() {}
};
-
-// Stubs to fill in the abstract method
-class ConcreteVirtualMethodsInHeaders : public VirtualMethodsInHeaders {
- public:
- void MethodIsAbstract() override {}
-};
-
-class ConcreteVirtualMethodsInImplementation
- : public VirtualMethodsInImplementation {
- public:
- void MethodIsAbstract() override {}
-};
-
-// Fill in the implementations
-void VirtualMethodsInHeaders::MethodHasNoArguments() {
-}
-void WarnOnMissingVirtual::MethodHasNoArguments() {
-}
-void VirtualMethodsInImplementation::MethodHasNoArguments() {
-}
-
-int main() {
- ConcreteVirtualMethodsInHeaders one;
- ConcreteVirtualMethodsInImplementation two;
-}

Powered by Google App Engine
This is Rietveld 408576698