Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: tools/clang/plugins/tests/virtual_bodies.cpp

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "virtual_bodies.h" 5 #include "virtual_bodies.h"
6 6
7 // Shouldn't warn about method usage in the implementation file. 7 // Shouldn't warn about method usage in the implementation file.
8 class VirtualMethodsInImplementation { 8 class VirtualMethodsInImplementation {
9 public: 9 public:
10 virtual void MethodIsAbstract() = 0; 10 // Complain about the inline/missing constructor.
11 virtual void MethodHasNoArguments(); 11 virtual void Method1() {}
12 virtual void MethodHasEmptyDefaultImpl() {} 12 virtual bool Method2() { return true; }
13 virtual bool ComplainAboutThis() { return true; } 13 virtual void Method3() {}
14 virtual bool Method4() { return true; }
15 virtual void Method5() {}
14 }; 16 };
15
16 // Stubs to fill in the abstract method
17 class ConcreteVirtualMethodsInHeaders : public VirtualMethodsInHeaders {
18 public:
19 void MethodIsAbstract() override {}
20 };
21
22 class ConcreteVirtualMethodsInImplementation
23 : public VirtualMethodsInImplementation {
24 public:
25 void MethodIsAbstract() override {}
26 };
27
28 // Fill in the implementations
29 void VirtualMethodsInHeaders::MethodHasNoArguments() {
30 }
31 void WarnOnMissingVirtual::MethodHasNoArguments() {
32 }
33 void VirtualMethodsInImplementation::MethodHasNoArguments() {
34 }
35
36 int main() {
37 ConcreteVirtualMethodsInHeaders one;
38 ConcreteVirtualMethodsInImplementation two;
39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698