tools/clang/plugins/tests/overridden_methods.txt - Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule.

Unified Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/overridden_methods.h ('k') | tools/clang/plugins/tests/test.sh » ('j') | tools/clang/plugins/tests/test.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/plugins/tests/overridden_methods.txt

diff --git a/tools/clang/plugins/tests/overridden_methods.txt b/tools/clang/plugins/tests/overridden_methods.txt

index 037d4348bc00fb054cb18da7c4d55d6fc87f5ce1..7d71c4b82a78024e31606fe4b3d5c5ca72b7742b 100644

--- a/tools/clang/plugins/tests/overridden_methods.txt

+++ b/tools/clang/plugins/tests/overridden_methods.txt

@@ -7,43 +7,43 @@ In file included from overridden_methods.cpp:5:

virtual void WebKitModifiedSomething() {};

override

-./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:47:27: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual ~DerivedClass() {}

override

-./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:49:28: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeMethod();

override

-./overridden_methods.h:52:35: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:53:35: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeInlineMethod() {}

override

-./overridden_methods.h:54:41: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:55:41: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void WebKitModifiedSomething();

override

-./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:57:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeConstMethod() const {}

override

-./overridden_methods.h:58:54: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:59:54: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeMethodWithExceptionSpec() throw() {}

override

-./overridden_methods.h:61:68: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:62:68: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}

override

-./overridden_methods.h:63:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:64:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeNonPureBaseMethod() {}

override

-./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:66:39: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeMethodWithComment(); // This is a comment.

override

-./overridden_methods.h:67:47: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

+./overridden_methods.h:68:47: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.

virtual void SomeMethodWithCommentAndBody() {} // This is a comment.

override