Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/overridden_methods.h ('k') | tools/clang/plugins/tests/test.sh » ('j') | tools/clang/plugins/tests/test.sh » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:25:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 2 ./overridden_methods.h:25:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod() = 0; 3 virtual void SomeMethod() = 0;
4 ^ 4 ^
5 override 5 override
6 ./overridden_methods.h:38:42: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 6 ./overridden_methods.h:38:42: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual void WebKitModifiedSomething() {}; 7 virtual void WebKitModifiedSomething() {};
8 ^ 8 ^
9 override 9 override
10 ./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:47:27: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual ~DerivedClass() {} 11 virtual ~DerivedClass() {}
12 ^ 12 ^
13 override 13 override
14 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 14 ./overridden_methods.h:49:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
15 virtual void SomeMethod(); 15 virtual void SomeMethod();
16 ^ 16 ^
17 override 17 override
18 ./overridden_methods.h:52:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 18 ./overridden_methods.h:53:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
19 virtual void SomeInlineMethod() {} 19 virtual void SomeInlineMethod() {}
20 ^ 20 ^
21 override 21 override
22 ./overridden_methods.h:54:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 22 ./overridden_methods.h:55:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
23 virtual void WebKitModifiedSomething(); 23 virtual void WebKitModifiedSomething();
24 ^ 24 ^
25 override 25 override
26 ./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 26 ./overridden_methods.h:57:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
27 virtual void SomeConstMethod() const {} 27 virtual void SomeConstMethod() const {}
28 ^ 28 ^
29 override 29 override
30 ./overridden_methods.h:58:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 30 ./overridden_methods.h:59:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
31 virtual void SomeMethodWithExceptionSpec() throw() {} 31 virtual void SomeMethodWithExceptionSpec() throw() {}
32 ^ 32 ^
33 override 33 override
34 ./overridden_methods.h:61:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 ./overridden_methods.h:62:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
35 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 35 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
36 ^ 36 ^
37 override 37 override
38 ./overridden_methods.h:63:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 38 ./overridden_methods.h:64:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
39 virtual void SomeNonPureBaseMethod() {} 39 virtual void SomeNonPureBaseMethod() {}
40 ^ 40 ^
41 override 41 override
42 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 42 ./overridden_methods.h:66:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeMethodWithComment(); // This is a comment. 43 virtual void SomeMethodWithComment(); // This is a comment.
44 ^ 44 ^
45 override 45 override
46 ./overridden_methods.h:67:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 46 ./overridden_methods.h:68:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
47 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 47 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
48 ^ 48 ^
49 override 49 override
50 overridden_methods.cpp:15:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 50 overridden_methods.cpp:15:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
51 virtual void SomeMethod() = 0; 51 virtual void SomeMethod() = 0;
52 ^ 52 ^
53 override 53 override
54 overridden_methods.cpp:22:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 54 overridden_methods.cpp:22:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
55 virtual ~ImplementationDerivedClass() {} 55 virtual ~ImplementationDerivedClass() {}
56 ^ 56 ^
(...skipping 28 matching lines...) Expand all
85 override 85 override
86 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 86 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
87 virtual void SomeMethodWithComment(); // This is a comment. 87 virtual void SomeMethodWithComment(); // This is a comment.
88 ^ 88 ^
89 override 89 override
90 overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 90 overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
91 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 91 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
92 ^ 92 ^
93 override 93 override
94 23 warnings generated. 94 23 warnings generated.
OLDNEW
« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/tests/overridden_methods.h ('k') | tools/clang/plugins/tests/test.sh » ('j') | tools/clang/plugins/tests/test.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698