tools/clang/plugins/tests/overridden_methods.h - Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/overridden_methods.h

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/tests/overridden_methods.h

diff --git a/tools/clang/plugins/tests/overridden_methods.h b/tools/clang/plugins/tests/overridden_methods.h

index ed29933456894549b332da271af8027a26ff253f..8f33d8d0e119b43cc1940b74328e5240a48fef8c 100644

--- a/tools/clang/plugins/tests/overridden_methods.h

+++ b/tools/clang/plugins/tests/overridden_methods.h

@@ -42,6 +42,7 @@ class WebKitObserverImpl : blink::WebKitObserver {

class DerivedClass : public InterimClass,

public webkit_glue::WebKitObserverImpl {

public:

+ DerivedClass();

// Should warn about destructors.

virtual ~DerivedClass() {}

// Should warn.