Disallow invalid package names in Pubspec.

Disallow invalid package names in Pubspec.

Previously these names were only disallowed when publishing, but now the
package config format requires that we be more stringent about them.

Closes #1361

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/8c091bf6332e8b392fdac63ae297426fb65ed925

[Bob Nystrom, 2015-12-01 23:21:15]

LGTM!

We'll probably need to mention this in the SDK release notes as a breaking
change.

https://codereview.chromium.org/1493463002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1493463002/diff/1/lib/src/utils.dart#newcode25
lib/src/utils.dart:25: final identifierRegExp = new
RegExp(r"[a-zA-Z_][a-zA-Z0-9_]*");
"\w+" or "[a-zA-Z_]\w*"

?

https://codereview.chromium.org/1493463002/diff/1/test/get/package_name_test....
File test/get/package_name_test.dart (right):

https://codereview.chromium.org/1493463002/diff/1/test/get/package_name_test....
test/get/package_name_test.dart:69: });
What about "for.if.return"?

[nweiz, 2015-12-02 00:28:05]

Code review changes

[nweiz, 2015-12-02 00:29:01]

https://codereview.chromium.org/1493463002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/1493463002/diff/1/lib/src/utils.dart#newcode25
lib/src/utils.dart:25: final identifierRegExp = new
RegExp(r"[a-zA-Z_][a-zA-Z0-9_]*");
On 2015/12/01 23:21:15, Bob Nystrom wrote:
> "\w+" or "[a-zA-Z_]\w*"
> 
> ?

Done.

https://codereview.chromium.org/1493463002/diff/1/test/get/package_name_test....
File test/get/package_name_test.dart (right):

https://codereview.chromium.org/1493463002/diff/1/test/get/package_name_test....
test/get/package_name_test.dart:69: });
On 2015/12/01 23:21:15, Bob Nystrom wrote:
> What about "for.if.return"?

I don't particularly mind if someone does that. Once they're in dotted land,
they can't use the name as an identifier anyway.

[nweiz, 2015-12-02 00:30:16]

Description was changed from

==========
Disallow invalid package names in Pubspec.

Previously these names were only disallowed when publishing, but now the
package config format requires that we be more stringent about them.

Closes #1361

R=rnystrom@google.com
==========

to

==========
Disallow invalid package names in Pubspec.

Previously these names were only disallowed when publishing, but now the
package config format requires that we be more stringent about them.

Closes #1361

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/8c091bf6332e8b392fdac63ae297426fb65ed925
==========

[nweiz, 2015-12-02 00:30:18]

Committed patchset #2 (id:20001) manually as
8c091bf6332e8b392fdac63ae297426fb65ed925 (presubmit successful).