Disallow invalid package names in Pubspec.

lib/src/utils.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Generic utility functions. Stuff that should possibly be in core.
 library pub.utils;
 
 import 'dart:async';
 import "dart:convert";
 import 'dart:io';
 
 import "package:crypto/crypto.dart";
 import 'package:path/path.dart' as path;
 import "package:stack_trace/stack_trace.dart";
 
 import 'exceptions.dart';
 import 'io.dart';
 import 'log.dart' as log;
 
 export 'asset/dart/utils.dart';
 
 /// A regular expression matching a Dart identifier.
 ///
 /// This also matches a package name, since they must be Dart identifiers.
-final identifierRegExp = new RegExp(r"[a-zA-Z_][a-zA-Z0-9_]+");
+final identifierRegExp = new RegExp(r"[a-zA-Z_][a-zA-Z0-9_]*");

[Bob Nystrom, 2015/12/01 23:21:15]

"\w+" or "[a-zA-Z_]\w*"

?

[nweiz, 2015/12/02 00:29:01]

Done.

 
 /// Like [identifierRegExp], but anchored so that it only matches strings that
 /// are *just* Dart identifiers.
 final onlyIdentifierRegExp = new RegExp("^${identifierRegExp.pattern}\$");
 
+/// Dart reserved words, from the Dart spec.
+const reservedWords = const [
+  "assert", "break", "case", "catch", "class", "const", "continue", "default",
+  "do", "else", "extends", "false", "final", "finally", "for", "if", "in", "is",
+  "new", "null", "return", "super", "switch", "this", "throw", "true", "try",
+  "var", "void", "while", "with"
+];
+
 /// A pair of values.
 class Pair<E, F> {
   E first;
   F last;
 
   Pair(this.first, this.last);
 
   String toString() => '($first, $last)';
 
   bool operator==(other) {
@@ skipping 893 matching lines @@
   } else {
     throw new ApplicationException(message);
   }
 }
 
 /// Throw a [DataException] with [message] to indicate that the command has
 /// failed because of invalid input data.
 ///
 /// This will report the error and cause pub to exit with [exit_codes.DATA].
 void dataError(String message) => throw new DataException(message);