Disallow invalid package names in Pubspec.

lib/src/pubspec.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.pubspec;
 
 import 'package:path/path.dart' as path;
 import 'package:pub_semver/pub_semver.dart';
 import 'package:source_span/source_span.dart';
 import 'package:yaml/yaml.dart';
 
 import 'barback/transformer_config.dart';
 import 'exceptions.dart';
 import 'io.dart';
 import 'package.dart';
 import 'source_registry.dart';
 import 'utils.dart';
 
+/// A regular expression matching allowed package names.
+///
+/// This allows dot-separated valid Dart identifiers. The dots are there for
+/// compatibility with Google's internal Dart packages, but they may not be used
+/// when publishing a package to pub.dartlang.org.
+final _packageName = new RegExp(
+    "^${identifierRegExp.pattern}(\\.${identifierRegExp.pattern})*\$");
+
 /// The parsed contents of a pubspec file.
 ///
 /// The fields of a pubspec are, for the most part, validated when they're first
 /// accessed. This allows a partially-invalid pubspec to be used if only the
 /// valid portions are relevant. To get a list of all errors in the pubspec, use
 /// [allErrors].
 class Pubspec {
   // If a new lazily-initialized field is added to this class and the
   // initialization can throw a [PubspecException], that error should also be
   // exposed through [allErrors].
@@ skipping 20 matching lines @@
   String get name {
     if (_name != null) return _name;
 
     var name = fields['name'];
     if (name == null) {
       throw new PubspecException(
           'Missing the required "name" field.', fields.span);
     } else if (name is! String) {
       throw new PubspecException(
           '"name" field must be a string.', fields.nodes['name'].span);
+    } else if (!_packageName.hasMatch(name)) {
+      throw new PubspecException(
+          '"name" field must be a valid Dart identifier.',
+          fields.nodes['name'].span);
+    } else if (reservedWords.contains(name)) {
+      throw new PubspecException(
+          '"name" field may not be a Dart reserved word.',
+          fields.nodes['name'].span);
     }
 
     _name = name;
     return _name;
   }
   String _name;
 
   /// The package's version.
   Version get version {
     if (_version != null) return _version;
@@ skipping 510 matching lines @@
     implements ApplicationException {
   PubspecException(String message, SourceSpan span)
       : super(message, span);
 }
 
 /// Returns whether [uri] is a file URI.
 ///
 /// This is slightly more complicated than just checking if the scheme is
 /// 'file', since relative URIs also refer to the filesystem on the VM.
 bool _isFileUri(Uri uri) => uri.scheme == 'file' || uri.scheme == '';