Move loops that chain together effects into GrGLShaderBuilder from GrGLProgram.

Move loops that chain together effects into GrGLShaderBuilder from GrGLProgram.

R=robertphillips@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9073

[bsalomon, 2013-05-08 19:32:52]

The motivation for this change is to make GrGLShaderBuilder know which effect is
generating code when it sees a call to fragmentPosition() and dstColor(). It
also pushes us in the direction of moving code generation from GrGLProgram to
GrGLShaderBuilder.

[robertphillips, 2013-05-08 19:56:33]

lgtm + nits

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:223: if (fCodeStage.inStageCode()) {
This '__' behavior should probably be mentioned in the comment

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:444:
fGSOutputs.back().setTypeModifier(GrGLShaderVar::kVaryingOut_TypeModifier);
Did you mean to change this from 'g' to 'd'?

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:625: int effectCnt,
xtra space?

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:680: SkString openBrace;
extra space in "] ->name"

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.h:290: int effectCnt,
xtra space here?

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.h:366: 
AutoStageRestore?

[bsalomon, 2013-05-08 20:38:54]

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:223: if (fCodeStage.inStageCode()) {
On 2013/05/08 19:56:33, robertphillips wrote:
> This '__' behavior should probably be mentioned in the comment

Two things: 1) It's a private function. 2) We don't want the caller to rely on
any particular behavior. I'm going to update the comment to be more vague rather
than promise a particular name-mangling.

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:444:
fGSOutputs.back().setTypeModifier(GrGLShaderVar::kVaryingOut_TypeModifier);
On 2013/05/08 19:56:33, robertphillips wrote:
> Did you mean to change this from 'g' to 'd'?

Done.

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:625: int effectCnt,
On 2013/05/08 19:56:33, robertphillips wrote:
> xtra space?

Done.

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.cpp:680: SkString openBrace;
On 2013/05/08 19:56:33, robertphillips wrote:
> extra space in "] ->name"

Done.

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/14925010/diff/4001/src/gpu/gl/GrGLShaderBuild...
src/gpu/gl/GrGLShaderBuilder.h:366: 
On 2013/05/08 19:56:33, robertphillips wrote:
> AutoStageRestore?

Done.

[bsalomon, 2013-05-09 13:45:16]

Committed patchset #4 manually as r9073 (presubmit successful).