Chromium Code Reviews
Help | Chromium Project | Sign in
(399)

Issue 14924002: WebUI for Profile Settings Reset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 2 weeks ago by battre (OOO)
Modified:
10 months, 3 weeks ago
CC:
chromium-reviews_chromium.org, dbeam+watch-options_chromium.org, arv+watch_chromium.org, vasilii, Evan Stade, James Hawkins
Visibility:
Public.

Description

WebUI for Profile Settings Reset

This CL implements chrome://settings/profileSettingsReset, a feature to reset
profile settings that malware often modifies.

BUG=235037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202064

Patch Set 1 #

Patch Set 2 : Nits #

Patch Set 3 : Fix browser test #

Total comments: 6

Patch Set 4 : Merged with ToT #

Patch Set 5 : Addressed vasilii's comments and fixed a merge error #

Total comments: 20

Patch Set 6 : Merged with ToT #

Patch Set 7 : Addressed comments #

Total comments: 28

Patch Set 8 : Merged with ToT #

Patch Set 9 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -0 lines) Lint Patch
M chrome/app/generated_resources.grd View 2 chunks +47 lines, -0 lines 0 comments ? errors Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/profile_resetter/profile_resetter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/options.html View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/options.js View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/options_bundle.js View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments ? errors Download
A chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 2 3 4 5 6 7 8 1 chunk +18 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/options/reset_profile_settings_overlay.html View 1 2 3 4 5 6 1 chunk +69 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 2 3 4 5 6 7 8 1 chunk +112 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/browser_ui_prefs.cc View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/ui/webui/options/profile_settings_reset_browsertest.js View 1 2 3 4 5 6 7 8 1 chunk +25 lines, -0 lines 0 comments ? errors Download
A chrome/browser/ui/webui/options/reset_profile_settings_handler.h View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments 1 errors Download
A chrome/browser/ui/webui/options/reset_profile_settings_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +133 lines, -0 lines 0 comments 1 errors Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments 0 errors Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 24
battre (OOO)
Hi Evan, may I ask you you review this CL? I'll share the design document ...
11 months, 2 weeks ago #1
battre (OOO)
CC: vasilii FYI
11 months, 2 weeks ago #2
Evan Stade
sorry this CL fell off my radar. I've been focusing on preparing for i/o. Is ...
11 months, 1 week ago #3
battre (OOO)
Hi James, could you please review this CL? Thanks, Dominic
11 months, 1 week ago #4
battre (OOO)
Hi Dan, passing this on to you. Could you please review the CL? Thanks, Dominic
11 months, 1 week ago #5
vasilii
https://codereview.chromium.org/14924002/diff/9001/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/14924002/diff/9001/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode506 chrome/browser/ui/webui/options/browser_options_handler.cc:506: values->SetBoolean("enableProfileSection", Maybe enableResetProfileSection is a better name? https://codereview.chromium.org/14924002/diff/9001/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc File ...
11 months, 1 week ago #6
battre (OOO)
Thanks. https://codereview.chromium.org/14924002/diff/9001/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/14924002/diff/9001/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode506 chrome/browser/ui/webui/options/browser_options_handler.cc:506: values->SetBoolean("enableProfileSection", On 2013/05/13 09:13:06, vasilii wrote: > Maybe ...
11 months, 1 week ago #7
James Hawkins
https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html#newcode731 chrome/browser/resources/options/browser_options.html:731: <button id="reset-profile-settings-button" nit: Don't append the element name to ...
11 months, 1 week ago #8
battre (OOO)
Thank you. PTAL. Best regards, Dominic https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html#newcode731 chrome/browser/resources/options/browser_options.html:731: <button id="reset-profile-settings-button" On ...
11 months ago #9
battre (OOO)
+sky for OWNERS approval of chrome/browser/ui/browser_ui_prefs.cc
11 months ago #10
sky
https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/browser_ui_prefs.cc File chrome/browser/ui/browser_ui_prefs.cc (right): https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/browser_ui_prefs.cc#newcode223 chrome/browser/ui/browser_ui_prefs.cc:223: user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); I haven't been involved with this feature, so ...
11 months ago #11
battre (OOO)
https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/browser_ui_prefs.cc File chrome/browser/ui/browser_ui_prefs.cc (right): https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/browser_ui_prefs.cc#newcode223 chrome/browser/ui/browser_ui_prefs.cc:223: user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); On 2013/05/21 15:08:29, sky wrote: > I haven't ...
11 months ago #12
sky
Ah, ok. That makes sense. LGTM On Tue, May 21, 2013 at 9:29 AM, <battre@chromium.org> ...
11 months ago #13
vasilii
lgtm
10 months, 4 weeks ago #14
battre (OOO)
James, could you please have another look? Thanks. Dominic
10 months, 4 weeks ago #15
James Hawkins
LGTM with comments. https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html#newcode731 chrome/browser/resources/options/browser_options.html:731: <button id="reset-profile-settings-button" On 2013/05/21 09:25:08, battre ...
10 months, 4 weeks ago #16
Dan Beam
https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js File chrome/browser/resources/options/reset_profile_settings_overlay.js (right): https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js#newcode44 chrome/browser/resources/options/reset_profile_settings_overlay.js:44: for (var i = 0; i < checkboxes.length; i++) ...
10 months, 3 weeks ago #17
James Hawkins
https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js File chrome/browser/resources/options/reset_profile_settings_overlay.js (right): https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js#newcode44 chrome/browser/resources/options/reset_profile_settings_overlay.js:44: for (var i = 0; i < checkboxes.length; i++) ...
10 months, 3 weeks ago #18
Dan Beam
https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js File chrome/browser/resources/options/reset_profile_settings_overlay.js (right): https://chromiumcodereview.appspot.com/14924002/diff/37001/chrome/browser/resources/options/reset_profile_settings_overlay.js#newcode44 chrome/browser/resources/options/reset_profile_settings_overlay.js:44: for (var i = 0; i < checkboxes.length; i++) ...
10 months, 3 weeks ago #19
battre (OOO)
https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/14924002/diff/20025/chrome/browser/resources/options/browser_options.html#newcode731 chrome/browser/resources/options/browser_options.html:731: <button id="reset-profile-settings-button" On 2013/05/23 18:26:02, James Hawkins wrote: > ...
10 months, 3 weeks ago #20
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/14924002/60001
10 months, 3 weeks ago #21
I haz the power (commit-bot)
Change committed as 202064
10 months, 3 weeks ago #22
Dan Beam
https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc File chrome/browser/ui/webui/options/reset_profile_settings_handler.cc (right): https://codereview.chromium.org/14924002/diff/37001/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc#newcode92 chrome/browser/ui/webui/options/reset_profile_settings_handler.cc:92: const ListValue* /*value*/) { On 2013/05/24 09:15:46, battre wrote: ...
10 months, 3 weeks ago #23
Dan Beam
10 months, 3 weeks ago #24
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434