chrome/browser/resources/options/browser_options.html - Issue 14924002: WebUI for Profile Settings Reset

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 14924002: WebUI for Profile Settings Reset (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed vasilii's comments and fixed a merge error Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | chrome/browser/resources/options/reset_profile_settings_overlay.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="settings" class="page" hidden>	1 <div id="settings" class="page" hidden>

2 <header>	2 <header>

3 <h1 i18n-content="settingsTitle"></h1>	3 <h1 i18n-content="settingsTitle"></h1>

4 </header>	4 </header>

5 <if expr="not pp_ifdef('chromeos')">	5 <if expr="not pp_ifdef('chromeos')">

6 <include src="sync_section.html">	6 <include src="sync_section.html">

7 </if>	7 </if>

8 <if expr="pp_ifdef('chromeos')">	8 <if expr="pp_ifdef('chromeos')">

9 <section>	9 <section>

10 <h3 i18n-content="sectionTitleInternet"></h3>	10 <h3 i18n-content="sectionTitleInternet"></h3>

(...skipping 705 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
716 </span>	716 </span>

717 </div>	717 </div>

718 </section>	718 </section>

719 </if>	719 </if>

720 <section id="managed-user-settings-section" hidden>	720 <section id="managed-user-settings-section" hidden>

721 <h3 i18n-content="managedUsersSectionTitle"></h3>	721 <h3 i18n-content="managedUsersSectionTitle"></h3>

722 <button id="open-managed-user-settings-button"	722 <button id="open-managed-user-settings-button"

723 i18n-content="manageProfilesManagedUserSettings">	723 i18n-content="manageProfilesManagedUserSettings">

724 </button>	724 </button>

725 </section>	725 </section>

	726 <section id="reset-profile-settings-section" hidden>

	727 <h3 i18n-content="resetProfileSettingsSectionTitle"></h3>

	728 <div>

	729 <span class="settings-row" i18n-content="resetProfileSettingsDescription">

	730 </span>

	731 <button id="reset-profile-settings-button"
	James Hawkins 2013/05/13 17:31:33 nit: Don't append the element name to the ID, i.e. nit: Don't append the element name to the ID, i.e., remove "-button". battre 2013/05/21 09:25:08 How extensively do you want this to be done? It se Show quoted text On 2013/05/13 17:31:33, James Hawkins wrote: > nit: Don't append the element name to the ID, i.e., remove "-button". How extensively do you want this to be done? It seems to be pretty common practice to have "...-section" ids. I think that the "-button" suffix is pretty useful for distinction. Do you want me to modify the i18n label below as well? James Hawkins 2013/05/23 18:26:02 Yes; it suffices to call it 'resetProfileSettings' Show quoted text On 2013/05/21 09:25:08, battre wrote: > On 2013/05/13 17:31:33, James Hawkins wrote: > > nit: Don't append the element name to the ID, i.e., remove "-button". > > How extensively do you want this to be done? It seems to be pretty common > practice to have "...-section" ids. I think that the "-button" suffix is pretty > useful for distinction. Do you want me to modify the i18n label below as well? Yes; it suffices to call it 'resetProfileSettings'. battre 2013/05/24 09:15:46 Done. Show quoted text On 2013/05/23 18:26:02, James Hawkins wrote: > On 2013/05/21 09:25:08, battre wrote: > > On 2013/05/13 17:31:33, James Hawkins wrote: > > > nit: Don't append the element name to the ID, i.e., remove "-button". > > > > How extensively do you want this to be done? It seems to be pretty common > > practice to have "...-section" ids. I think that the "-button" suffix is > pretty > > useful for distinction. Do you want me to modify the i18n label below as well? > > Yes; it suffices to call it 'resetProfileSettings'. Done.
	732 i18n-content="resetProfileSettingsButton">

	733 </div>

	734 </section>

726 </div> <!-- advanced-settings-container -->	735 </div> <!-- advanced-settings-container -->

727 </div> <!-- advanced-settings -->	736 </div> <!-- advanced-settings -->

728 <footer>	737 <footer>

729 <button id="advanced-settings-expander" class="link-button"	738 <button id="advanced-settings-expander" class="link-button"

730 i18n-content="showAdvancedSettings">	739 i18n-content="showAdvancedSettings">

731 </button>	740 </button>

732 </footer>	741 </footer>

733 </div>	742 </div>

OLD	NEW