Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1492363002: Pass timeout to RepeatableScrollAction. (Closed)

Created:
5 years ago by ulan
Modified:
5 years ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass timeout to RepeatableScrollAction. This will allow benchmarks to make longer scroll actions. BUG=565306 Committed: https://crrev.com/f61a745f7c4fbc155a3e437d913acd9fe55953f3 Cr-Commit-Position: refs/heads/master@{#363060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M tools/telemetry/telemetry/internal/actions/repeatable_scroll.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/web_contents.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/action_runner.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
Sami, ptal.
5 years ago (2015-12-03 15:58:06 UTC) #2
Sami
lgtm.
5 years ago (2015-12-03 16:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492363002/1
5 years ago (2015-12-03 17:04:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 21:14:52 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 21:15:46 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f61a745f7c4fbc155a3e437d913acd9fe55953f3
Cr-Commit-Position: refs/heads/master@{#363060}

Powered by Google App Engine
This is Rietveld 408576698