Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: tools/telemetry/telemetry/internal/actions/repeatable_scroll.py

Issue 1492363002: Pass timeout to RepeatableScrollAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/browser/web_contents.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/actions/repeatable_scroll.py
diff --git a/tools/telemetry/telemetry/internal/actions/repeatable_scroll.py b/tools/telemetry/telemetry/internal/actions/repeatable_scroll.py
index ef33399d3e41b132645bd625718b38f399a7bfdc..79ba4c4f212576ba7c8a8f603915c30d93c3cec0 100644
--- a/tools/telemetry/telemetry/internal/actions/repeatable_scroll.py
+++ b/tools/telemetry/telemetry/internal/actions/repeatable_scroll.py
@@ -9,13 +9,14 @@ from telemetry.web_perf import timeline_interaction_record
class RepeatableScrollAction(page_action.PageAction):
def __init__(self, x_scroll_distance_ratio=0.0, y_scroll_distance_ratio=0.5,
- repeat_count=0, repeat_delay_ms=250):
+ repeat_count=0, repeat_delay_ms=250, timeout=60):
super(RepeatableScrollAction, self).__init__()
self._x_scroll_distance_ratio = x_scroll_distance_ratio
self._y_scroll_distance_ratio = y_scroll_distance_ratio
self._repeat_count = repeat_count
self._repeat_delay_ms = repeat_delay_ms
self._windowsize = []
+ self._timeout = timeout
def WillRunAction(self, tab):
# Get the dimensions of the screen.
@@ -35,4 +36,5 @@ class RepeatableScrollAction(page_action.PageAction):
repeatCount=self._repeat_count,
repeatDelayMs=self._repeat_delay_ms,
interactionMarkerName=timeline_interaction_record.GetJavaScriptMarker(
- 'Gesture_ScrollAction', [timeline_interaction_record.REPEATABLE]))
+ 'Gesture_ScrollAction', [timeline_interaction_record.REPEATABLE]),
+ timeout=self._timeout)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/browser/web_contents.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698