tools/telemetry/telemetry/page/action_runner.py - Issue 1492363002: Pass timeout to RepeatableScrollAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/action_runner.py

Issue 1492363002: Pass timeout to RepeatableScrollAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/action_runner.py

diff --git a/tools/telemetry/telemetry/page/action_runner.py b/tools/telemetry/telemetry/page/action_runner.py

index 805e62d6edffa844d5eb436b539023175bc1c177..d36a6c17d379e3a11f9ae67b520a1dd4238b4e07 100644

--- a/tools/telemetry/telemetry/page/action_runner.py

+++ b/tools/telemetry/telemetry/page/action_runner.py

@@ -362,7 +362,8 @@ class ActionRunner(object):

def RepeatableBrowserDrivenScroll(self, x_scroll_distance_ratio=0.0,

y_scroll_distance_ratio=0.5,

repeat_count=0,

- repeat_delay_ms=250):

+ repeat_delay_ms=250,

+ timeout=60):

"""Perform a browser driven repeatable scroll gesture.

The scroll gesture is driven from the browser, this is useful because the

@@ -381,7 +382,7 @@ class ActionRunner(object):

x_scroll_distance_ratio=x_scroll_distance_ratio,

y_scroll_distance_ratio=y_scroll_distance_ratio,

repeat_count=repeat_count,

- repeat_delay_ms=repeat_delay_ms))

+ repeat_delay_ms=repeat_delay_ms, timeout=timeout))

def ScrollElement(self, selector=None, text=None, element_function=None,

left_start_ratio=0.5, top_start_ratio=0.5,

« no previous file with comments | « tools/telemetry/telemetry/internal/browser/web_contents.py ('k') | no next file » | no next file with comments »